From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Fri, 17 Apr 2009 08:20:41 +0200 Subject: [U-Boot] [PATCH 0/7] Remove individual I2C commands and cleanup In-Reply-To: References: Message-ID: <49E81FB9.5000902@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Peter, Peter Tyser wrote: > This patch series removes the "individual" I2C commands (and the > CONFIG_I2C_CMD_TREE define) and migrates all boards to the newer > "tree style" I2C commands. > > A small amount of cleanup was performed before and after removing > the individual commands. Thanks for your work, looks good to me. I make some tests with your patches, and if they are OK, I apply your patches to u-boot-i2c.git. Hmm.. maybe you can have a look at my posting: http://lists.denx.de/pipermail/u-boot/2009-March/049506.html There is a new i2c_core.c file which holds all "common" i2c functions, for example the i2c_[set|get]_bus_speed(). I think such a file is a better place for it. I wonder I get no response for cleaning up the i2c subsystem ... is here no interest in doing such a cleanup? (I think it is a necessary step ...) comments are welcome ;-) bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany