Re: [PATCH] Software receive packet steering

[Eric Dumazet <dada1@cosmosbay.com>]

Tom Herbert a écrit :
> On Mon, Apr 20, 2009 at 3:32 AM, Andi Kleen <andi@firstfloor.org> wrote:
>> Tom Herbert <therbert@google.com> writes:
>>
>>> +static int netif_cpu_for_rps(struct net_device *dev, struct sk_buff *skb)
>>> +{
>>> +     cpumask_t mask;
>>> +     unsigned int hash;
>>> +     int cpu, count = 0;
>>> +
>>> +     cpus_and(mask, dev->soft_rps_cpus, cpu_online_map);
>>> +     if (cpus_empty(mask))
>>> +             return smp_processor_id();
>> There's a race here with CPU hotunplug I think. When a CPU is hotunplugged
>> in parallel you can still push packets to it even though they are not
>> drained. You probably need some kind of drain callback in a CPU hotunplug
>> notifier that eats all packets left over.
>>
> We will look at that, the hotplug support may very well be lacking in the patch.
> 
>>> +got_hash:
>>> +     hash %= cpus_weight_nr(mask);
>> That looks rather heavyweight even on modern CPUs. I bet it's 40-50+ cycles
>> alone forth the hweight and the division. Surely that can be done better?
>>
> Agreed, I will try to pull in the RX hash from Dave Miller's remote
> softirq patch.
> 
>> Also I suspect some kind of runtime switch for this would be useful.
>>
>> Also the manual set up of the receive mask seems really clumpsy. Couldn't
>> you set that up dynamically based on where processes executing recvmsg()
>> are running?
>>
> We have done exactly that.  It works very well in many cases
> (application + platform combinations), but I haven't found it to be
> better than doing the hash in all cases.  I could provide the patch,
> but it might be more of a follow patch to this base one.

Hello Tom

I was thinking about your patch (and David's one), and thought it could be
possible to spread packets to other cpus only if current one is under stress.

A posssible metric would be to test if softirq is handled by ksoftirqd
(stress situation) or not.

Under moderate load, we could have one active cpu (and fewer cache line
transferts), keeping good latencies.

I tried alternative approach to solve the Multicast problem raised some time ago,
but still have one cpu handling one device. Only wakeups were defered to a
workqueue (and possibly another cpu) if running from ksoftirq only.
Patch not yet ready for review, but based on a previous patch that was more
intrusive (touching kernel/softirq.c)

Under stress, your idea permits to use more cpus for a fast NIC and get better
throughput. Its more generic.