From: David Ahern <dsahern@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] PATCH: enabling TCP keepalives on VNC connections
Date: Tue, 21 Apr 2009 13:21:48 -0600 [thread overview]
Message-ID: <49EE1CCC.8080205@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 310 bytes --]
This patch enables TCP keepalives on VNC connections for linux hosts.
After 60-seconds of idle time, probes are sent every 12 seconds with the
connection resetting after 5 failed probes (ie., connection is closed if
no response received in 60-seconds).
Signed-off-by: David Ahern <dsahern@gmail.com>
david
[-- Attachment #2: vnc-enable-keepalives.patch --]
[-- Type: text/plain, Size: 1778 bytes --]
diff --git a/vnc.c b/vnc.c
index ab1f044..7a8bbd7 100644
--- a/vnc.c
+++ b/vnc.c
@@ -32,6 +32,12 @@
#define VNC_REFRESH_INTERVAL (1000 / 30)
+#ifdef __linux__
+#define VNC_TCP_KEEPIDLE 60
+#define VNC_TCP_KEEPINTVL 12
+#define VNC_TCP_KEEPCNT 5
+#endif
+
#include "vnc_keysym.h"
#include "d3des.h"
@@ -2015,12 +2021,41 @@ static void vnc_listen_read(void *opaque)
VncDisplay *vs = opaque;
struct sockaddr_in addr;
socklen_t addrlen = sizeof(addr);
+ int val;
/* Catch-up */
vga_hw_update();
int csock = accept(vs->lsock, (struct sockaddr *)&addr, &addrlen);
if (csock != -1) {
+#ifdef __linux__
+ /* best effort to enable keep alives */
+ val = 1;
+ if (setsockopt(csock, SOL_SOCKET, SO_KEEPALIVE,
+ &val, sizeof(val)) < 0) {
+ fprintf(stderr, "VNC: failed to enable keepalives\n");
+ }
+
+ /* after N-seconds of idle time, send probes every X seconds
+ * dropping the connection after Y failed probes.
+ */
+ val = VNC_TCP_KEEPIDLE;
+ if (setsockopt(csock, IPPROTO_TCP, TCP_KEEPIDLE,
+ &val, sizeof(val)) < 0) {
+ fprintf(stderr, "VNC: failed to set tcp idle interval\n");
+ }
+ val = VNC_TCP_KEEPINTVL;
+ if (setsockopt(csock, IPPROTO_TCP, TCP_KEEPINTVL,
+ &val, sizeof(val)) < 0) {
+ fprintf(stderr, "VNC: failed to set tcp probe interval\n");
+ }
+ val = VNC_TCP_KEEPCNT;
+ if (setsockopt(csock, IPPROTO_TCP, TCP_KEEPCNT,
+ &val, sizeof(val)) < 0) {
+ fprintf(stderr, "VNC: failed to set tcp missed probe count\n");
+ }
+#endif
+
vnc_connect(vs, csock);
}
}
next reply other threads:[~2009-04-21 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 19:21 David Ahern [this message]
2009-04-21 20:06 [Qemu-devel] PATCH: enabling TCP keepalives on VNC connections David Ahern
2009-04-22 1:46 David Ahern
2009-04-22 1:48 David Ahern
2009-04-22 2:17 David S. Ahern
2009-04-22 18:26 ` Anthony Liguori
2009-04-22 21:22 ` David S. Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EE1CCC.8080205@gmail.com \
--to=dsahern@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.