From: Ian Abbott <abbotti@mev.co.uk>
To: Greg KH <greg@kroah.com>
Cc: Roel Kluin <roel.kluin@gmail.com>, Greg KH <gregkh@suse.de>,
lkml <linux-kernel@vger.kernel.org>,
Ian Abbott <ian.abbott@mev.co.uk>,
Frank Mori Hess <fmhess@users.sourceforge.net>,
David Schleef <ds@schleef.org>
Subject: Re: staging: comedi: non working tests on unsigned cmd->convert_arg
Date: Wed, 22 Apr 2009 18:59:33 +0100 [thread overview]
Message-ID: <49EF5B05.6080402@mev.co.uk> (raw)
In-Reply-To: <20090422165049.GC19524@kroah.com>
On 22/04/09 17:50, Greg KH wrote:
> On Tue, Apr 21, 2009 at 03:18:10PM +0200, Roel Kluin wrote:
>> vi drivers/staging/comedi/comedi.h +342
>>
>> and note that cmd->convert_arg in s626_ai_cmdtest() is unsigned. Should there
>> maybe be a test:
>>
>> if (cmd->convert_src == TRIG_EXT && cmd->convert_arg > MAX)
>>
>> (and what should MAX be then?)
>
> I don't know. Let's ask the comedi developers :)
>
> Frank, what do you think about this?
Ian here. I'd just delete that 'if' statement entirely as the test is
never true and it is followed by another 'if' statement that tests the
maximum value.
The similar 'if' statements that test cmd->start_arg < 0, and
cmd->scan_begin_arg < 0 can also be removed.
>> Otherwise you may want to apply the cleanup patch below
>>
>> Roel
>> ------------------------------>8-------------8<---------------------------------
>> Remove redundant tests on unsigned
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c
>> index 30dec9d..928c4c6 100644
>> --- a/drivers/staging/comedi/drivers/s626.c
>> +++ b/drivers/staging/comedi/drivers/s626.c
>> @@ -1906,7 +1906,7 @@ static int s626_ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s
>> err++;
>> }
>>
>> - if (cmd->convert_src == TRIG_EXT && cmd->convert_arg < 0) {
>> + if (cmd->convert_src == TRIG_EXT) {
>> cmd->convert_arg = 0;
>> err++;
>> }
That should be:
- if (cmd->convert_src == TRIG_EXT && cmd->convert_arg < 0) {
- cmd->convert_arg = 0;
- err++;
- }
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2009-04-22 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-21 13:18 staging: comedi: non working tests on unsigned cmd->convert_arg Roel Kluin
2009-04-21 13:22 ` Roel Kluin
2009-04-22 16:50 ` Greg KH
2009-04-22 17:59 ` Ian Abbott [this message]
[not found] ` <200904221411.13851.fmhess@speakeasy.net>
2009-04-23 2:08 ` Greg KH
2009-04-23 10:23 ` Roel Kluin
2009-04-23 10:53 ` Ian Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49EF5B05.6080402@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=ds@schleef.org \
--cc=fmhess@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=ian.abbott@mev.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.