From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LwjWn-0007C4-2p
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:58:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LwjWi-0007Bp-Hk
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:58:44 -0400
Received: from [199.232.76.173] (port=36979 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LwjWi-0007Bm-Bv
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:58:40 -0400
Received: from wa-out-1112.google.com ([209.85.146.178]:17856)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LwjWh-0005IK-VA
	for qemu-devel@nongnu.org; Wed, 22 Apr 2009 16:58:40 -0400
Received: by wa-out-1112.google.com with SMTP id m33so69565wag.18
	for <qemu-devel@nongnu.org>; Wed, 22 Apr 2009 13:58:38 -0700 (PDT)
Message-ID: <49EF84FB.2000100@codemonkey.ws>
Date: Wed, 22 Apr 2009 15:58:35 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch 05/14] qemu: factor out special event
	notification
References: <20090422191504.975476933@localhost.localdomain>
	<20090422192119.869018048@localhost.localdomain>
In-Reply-To: <20090422192119.869018048@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mtosatti@redhat.com
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

mtosatti@redhat.com wrote:
> Special events that have no particular event descriptor (either fd for UNIX
> or HANDLE for Windows) associated with make use of an artificial one.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Index: trunk/vl.c
> ===================================================================
> --- trunk.orig/vl.c
> +++ trunk/vl.c
> @@ -921,15 +921,11 @@ static void qemu_rearm_alarm_timer(struc
>  #define MIN_TIMER_REARM_US 250
>  
>  static struct qemu_alarm_timer *alarm_timer;
> -#ifndef _WIN32
> -static int alarm_timer_rfd, alarm_timer_wfd;
> -#endif
>  
>  #ifdef _WIN32
>  
>  struct qemu_alarm_win32 {
>      MMRESULT timerId;
> -    HANDLE host_alarm;
>      unsigned int period;
>  } alarm_win32_data = {0, NULL, -1};
>  

There are a number of spots in vl.c that do 
CloseHandle(data->host_alarm) that aren't removed in this patch.  For 
instance, the error path in win32_start_timer().

Regards,

Anthony Liguori