All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, bzolnier@gmail.com
Subject: Re: [PATCH 07/14] block: reorganize request fetching functions
Date: Thu, 23 Apr 2009 10:23:03 +0900	[thread overview]
Message-ID: <49EFC2F7.9050906@kernel.org> (raw)
In-Reply-To: <20090422100916.GZ4593@kernel.dk>

Jens Axboe wrote:
> On Tue, Apr 21 2009, Christoph Hellwig wrote:
>> On Wed, Apr 22, 2009 at 01:37:54AM +0900, Tejun Heo wrote:
>>> Impact: code reorganization
>>>
>>> elv_next_request() and elv_dequeue_request() are public block layer
>>> interface than actual elevator implementation.  They mostly deal with
>>> how requests interact with block layer and low level drivers at the
>>> beginning of rqeuest processing whereas __elv_next_request() is the
>>> actual eleveator request fetching interface.
>>>
>>> Move the two functions to blk-core.c.  This prepares for further
>>> interface cleanup.
>> As a follow-up patch you might want to rename them to have a more
>> descriptive prefix than elv_ and add some kerneldoc comments for them.
> 
> Hmm dunno, elv_ is fine with me. kerneldoc is always nice, though.
> 

Both changes are scheduled down the pipeline.

Thanks.

-- 
tejun

  reply	other threads:[~2009-04-23  1:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21 16:37 [GIT PATCH linux-2.6-block] block: cleanup patches, take#3 Tejun Heo
2009-04-21 16:37 ` [PATCH 01/14] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-04-21 16:37 ` [PATCH 02/14] block: kill blk_start_queueing() Tejun Heo
2009-04-21 16:37 ` [PATCH 03/14] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-04-21 16:37 ` [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages Tejun Heo
2009-04-21 16:37 ` [PATCH 05/14] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-04-21 16:37 ` [PATCH 06/14] block: reorder request completion functions Tejun Heo
2009-04-21 16:37 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo
2009-04-21 17:07   ` Christoph Hellwig
2009-04-22 10:09     ` Jens Axboe
2009-04-23  1:23       ` Tejun Heo [this message]
2009-04-21 16:37 ` [PATCH 08/14] block: kill blk_end_request_callback() Tejun Heo
2009-04-21 16:37 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-04-21 17:59   ` Christoph Hellwig
2009-04-23  1:24     ` Tejun Heo
2009-04-23  2:08       ` [PATCH UPDATED " Tejun Heo
2009-04-23  9:43         ` Boaz Harrosh
2009-04-23  9:59           ` Tejun Heo
2009-04-21 16:37 ` [PATCH 10/14] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-04-21 16:37 ` [PATCH 11/14] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-04-21 16:37 ` [PATCH 12/14] block: replace end_request() with [__]blk_end_request_cur() Tejun Heo
2009-04-21 18:25   ` Joerg Dorchain
2009-04-21 20:35   ` Laurent Vivier
2009-04-22  9:25   ` Geert Uytterhoeven
2009-04-22 16:04   ` Grant Likely
2009-04-21 16:38 ` [PATCH 13/14] block: don't abuse rq->data Tejun Heo
2009-04-21 16:38 ` [PATCH 14/14] block-kill-data Tejun Heo
2009-04-21 16:42   ` [PATCH 14/14] block: kill rq->data Tejun Heo
2009-04-22 10:10 ` [GIT PATCH linux-2.6-block] block: cleanup patches, take#3 Jens Axboe
2009-04-23  2:10   ` Tejun Heo
2009-04-23  6:09     ` Jens Axboe
  -- strict thread matches above, loose matches on Subject: below --
2009-03-13  5:02 [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-13  5:02 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EFC2F7.9050906@kernel.org \
    --to=tj@kernel.org \
    --cc=bzolnier@gmail.com \
    --cc=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.