All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhaolei <zhaolei@cn.fujitsu.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Tom Zanussi <tzanussi@gmail.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Oleg Nesterov <oleg@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/4] tracing/workqueue: Use list_for_each_entry instrad of list_for_each_entry_safe in probe_workqueue_destruction()
Date: Tue, 28 Apr 2009 18:54:26 +0800	[thread overview]
Message-ID: <49F6E062.7040401@cn.fujitsu.com> (raw)
In-Reply-To: <49F6DFB5.2040901@cn.fujitsu.com>

No need to use list_for_each_entry_safe() because we just remove one list node
which is first found in list iteration.
(we don't continue list iteration after remove list node)

Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
---
 kernel/trace/trace_workqueue.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace_workqueue.c b/kernel/trace/trace_workqueue.c
index 51ed57e..b995bc0 100644
--- a/kernel/trace/trace_workqueue.c
+++ b/kernel/trace/trace_workqueue.c
@@ -206,12 +206,11 @@ static void probe_workqueue_destruction(struct task_struct *wq_thread)
 {
 	/* Workqueue only execute on one cpu */
 	int cpu = cpumask_first(&wq_thread->cpus_allowed);
-	struct cpu_workqueue_stats *node, *next;
+	struct cpu_workqueue_stats *node;
 	unsigned long flags;
 
 	spin_lock_irqsave(&workqueue_cpu_stat(cpu)->lock, flags);
-	list_for_each_entry_safe(node, next, &workqueue_cpu_stat(cpu)->list,
-				 list) {
+	list_for_each_entry(node, &workqueue_cpu_stat(cpu)->list, list) {
 		struct workfunc_stats *wfstat, *wfstatnext;
 
 		if (node->task != wq_thread)
-- 
1.5.5.3



  parent reply	other threads:[~2009-04-28 10:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 10:51 [PATCH 0/4] workqueue_trace: Add max execution time mesurement for per worklet Zhaolei
2009-04-28 10:52 ` [PATCH 1/4] tracing/workqueue: turn workfunc_stats::inserted into unsigned int Zhaolei
2009-04-28 10:53 ` [PATCH 2/4] tracing/workqueue: Avoid accessing task_struct's member variable in stat file read Zhaolei
2009-04-28 10:54 ` Zhaolei [this message]
2009-04-28 10:57 ` [PATCH 4/4] tracing/workqueue: Add max execution time mesurement for per worklet Zhaolei
2009-04-28 17:14   ` Oleg Nesterov
2009-04-30  1:15     ` Zhaolei
2009-04-28 21:53 ` [PATCH 0/4] workqueue_trace: " Frederic Weisbecker
2009-04-29  7:06 ` Andrew Morton
2009-04-29 13:33   ` Frederic Weisbecker
2009-04-29 13:43     ` Steven Rostedt
2009-04-29 13:45     ` Steven Rostedt
2009-04-29 15:36       ` Andrew Morton
2009-04-29 15:49         ` Frederic Weisbecker
2009-04-29 19:10           ` Ingo Molnar
2009-04-30  1:10     ` [PATCH 0/4] workqueue_trace: Add max execution time mesurementfor " Zhaolei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F6E062.7040401@cn.fujitsu.com \
    --to=zhaolei@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.