From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: Re: linux-next: usb tree build failure Date: Thu, 30 Apr 2009 09:27:36 -0700 Message-ID: <49F9D178.8050706@oracle.com> References: <20090429171752.f70c7de1.sfr@canb.auug.org.au> <49F86FBC.5030802@oracle.com> <20090429153714.GB22297@kroah.com> <49F875EF.8030408@oracle.com> <20090429174448.GB29026@kroah.com> <49F8941A.8070504@oracle.com> <20090430161341.GC18495@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from acsinet11.oracle.com ([141.146.126.233]:56795 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764104AbZD3Q0a (ORCPT ); Thu, 30 Apr 2009 12:26:30 -0400 In-Reply-To: <20090430161341.GC18495@kroah.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Greg KH Cc: Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, Sarah Sharp Greg KH wrote: > On Wed, Apr 29, 2009 at 10:53:30AM -0700, Randy Dunlap wrote: >> Greg KH wrote: >>> On Wed, Apr 29, 2009 at 08:44:47AM -0700, Randy Dunlap wrote: >>>> Greg KH wrote: >>>>> On Wed, Apr 29, 2009 at 08:18:20AM -0700, Randy Dunlap wrote: >>>>>> Stephen Rothwell wrote: >>>>>>> Hi Greg, >>>>>>> >>>>>>> Today's linux-next build (powerpc allyesconfig) failed like this: >>>>>>> >>>>>>> drivers/usb/built-in.o: In function `.handle_event': >>>>>>> (.text+0x67dd0): multiple definition of `.handle_event' >>>>>>> drivers/pcmcia/built-in.o:(.text+0xcfcc): first defined here >>>>>>> drivers/usb/built-in.o: In function `handle_event': >>>>>>> (.opd+0x5bc8): multiple definition of `handle_event' >>>>>>> drivers/pcmcia/built-in.o:(.opd+0xed0): first defined here >>>>>> There's also this one: >>>>>> >>>>>> drivers/usb/host/xhci-mem.c:46: error: implicit declaration of function 'dma_pool_alloc' >>>>>> drivers/usb/host/xhci-mem.c:69: error: implicit declaration of function 'dma_pool_free' >>>>>> drivers/usb/host/xhci-mem.c:578: error: implicit declaration of function 'dma_pool_destroy' >>>>>> drivers/usb/host/xhci-mem.c:657: error: implicit declaration of function 'dma_pool_create' >>>>>> >>>>>> That file needs to >>>>>> #include >>>>> What arch had this problem? >>>> i386 >>> I can't duplicate this here, care to attach a .config? >> attached. But you don't need to be able to duplicate it. >> >> The source file obviously uses those interfaces, so it should >> include that header file. > > Ah, it's a PCI config issue, a Kbuild change will fix this. So I noticed, but it should still #include the header file since those interfaces are used. -- ~Randy