From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C33CDC433E0 for ; Tue, 7 Jul 2020 04:46:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F3AC20722 for ; Tue, 7 Jul 2020 04:46:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AFvqdwni" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F3AC20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsfVR-0008Aq-Qc for qemu-devel@archiver.kernel.org; Tue, 07 Jul 2020 00:46:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsfUj-0007lx-5V for qemu-devel@nongnu.org; Tue, 07 Jul 2020 00:46:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43130 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jsfUh-00080H-0H for qemu-devel@nongnu.org; Tue, 07 Jul 2020 00:46:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594097169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=cv9NwKtvV5plYEkcw6yeZql5KDZ3MkIGJuFXga+zbCQ=; b=AFvqdwnik6c6XobPMbLcyiAIBO98yBHv0hXXcv0X/TQryDJYFC1hd7gJorOPIHsLLx8t// N+Z6OdA5VDFV17087g680sJAQXQjcRLNU50kxdThsuD7UKoFz8BJO2ITgpjnNpWP9Qh4RU z9lPwkeZsXyNCdYD24Rc3N/NfUvQdUA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-ZFD-H6oZP5y72q5brZOLEA-1; Tue, 07 Jul 2020 00:46:08 -0400 X-MC-Unique: ZFD-H6oZP5y72q5brZOLEA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E68B3805EFC; Tue, 7 Jul 2020 04:46:06 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-77.ams2.redhat.com [10.36.112.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C5375C298; Tue, 7 Jul 2020 04:45:59 +0000 (UTC) Subject: Slow down with: 'Make "info qom-tree" show children sorted' To: Markus Armbruster , qemu-devel@nongnu.org References: <20200527084754.7531-1-armbru@redhat.com> <20200527084754.7531-3-armbru@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <49bea110-0a3d-5a40-6647-67b116fb41b5@redhat.com> Date: Tue, 7 Jul 2020 06:45:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200527084754.7531-3-armbru@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/07 00:46:09 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , berrange@redhat.com, ehabkost@redhat.com, =?UTF-8?Q?Alex_Benn=c3=a9e?= , mark.cave-ayland@ilande.co.uk, Greg Kurz , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , David Gibson , pbonzini@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 27/05/2020 10.47, Markus Armbruster wrote: > "info qom-tree" prints children in unstable order. This is a pain > when diffing output for different versions to find change. Print it > sorted. > > Signed-off-by: Markus Armbruster > --- > qom/qom-hmp-cmds.c | 24 ++++++++++++++++-------- > 1 file changed, 16 insertions(+), 8 deletions(-) Hi Markus, this patch causes a slow down of the qtests which becomes quite massive when e.g. using the ppc64 and thourough testing. When I'm running QTEST_QEMU_BINARY="ppc64-softmmu/qemu-system-ppc64" time \ ./tests/qtest/device-introspect-test -m slow | tail -n 10 the test runs for ca. 6m40s here before the patch got applied, and for mor than 20 minutes after the patch got applied! This causes our gitlab CI to constantly fail since the patch got merged, since the testing time now exceeds the 1h time limit: https://gitlab.com/qemu-project/qemu/-/pipelines/156767175 Sure, we can work around that problem in the CI (Alex has already a patch queued), but still, is there something you could do about this massive slowdown? Thanks, Thomas