Re: [oe] [PATCH 01/17] giflib: upgrade 5.1.4 -> 5.2.1

From: "Khem Raj" <raj.khem@gmail.com>
To: "Andreas Müller" <schnitzeltony@gmail.com>,
	openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [PATCH 01/17] giflib: upgrade 5.1.4 -> 5.2.1
Date: Fri, 21 May 2021 19:59:21 -0700	[thread overview]
Message-ID: <49c18c1b-9c00-a1c0-c2f5-c8070195dfc0@gmail.com> (raw)
In-Reply-To: <20210522013521.588774-1-schnitzeltony@gmail.com>

On 5/21/21 6:35 PM, Andreas Müller wrote:
> Checked sources: Back ported CVE-patch can go
> 
> Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
> ---
>   .../giflib/files/CVE-2019-15133.patch         | 23 -------------------
>   .../{giflib_5.1.4.bb => giflib_5.2.1.bb}      | 19 ++++++++-------
>   2 files changed, 11 insertions(+), 31 deletions(-)
>   delete mode 100644 meta-oe/recipes-devtools/giflib/files/CVE-2019-15133.patch
>   rename meta-oe/recipes-devtools/giflib/{giflib_5.1.4.bb => giflib_5.2.1.bb} (54%)
> 
> diff --git a/meta-oe/recipes-devtools/giflib/files/CVE-2019-15133.patch b/meta-oe/recipes-devtools/giflib/files/CVE-2019-15133.patch
> deleted file mode 100644
> index 9957be82f..000000000
> --- a/meta-oe/recipes-devtools/giflib/files/CVE-2019-15133.patch
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -From 799eb6a3af8a3dd81e2429bf11a72a57e541f908 Mon Sep 17 00:00:00 2001
> -From: "Eric S. Raymond" <esr@thyrsus.com>
> -Date: Sun, 17 Mar 2019 12:37:21 -0400
> -Subject: [PATCH] Address SF bug #119: MemorySanitizer: FPE on unknown address
> -
> ----
> - dgif_lib.c | 2 +-
> - 1 file changed, 1 insertion(+), 1 deletion(-)
> -
> -Upstream-status: Backport [https://sourceforge.net/p/giflib/code/ci/799eb6a3af8a3dd81e2429bf11a72a57e541f908/]
> -CVE: CVE-2019-15133
> -
> ---- a/lib/dgif_lib.c	2021-01-13 19:28:18.923493586 +0100
> -+++ b/lib/dgif_lib.c	2021-01-13 19:28:55.245863085 +0100
> -@@ -1099,7 +1099,7 @@ DGifSlurp(GifFileType *GifFile)
> -
> -               sp = &GifFile->SavedImages[GifFile->ImageCount - 1];
> -               /* Allocate memory for the image */
> --              if (sp->ImageDesc.Width < 0 && sp->ImageDesc.Height < 0 &&
> -+              if (sp->ImageDesc.Width <= 0 && sp->ImageDesc.Height <= 0 &&
> -                       sp->ImageDesc.Width > (INT_MAX / sp->ImageDesc.Height)) {
> -                   return GIF_ERROR;
> -               }
> diff --git a/meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb b/meta-oe/recipes-devtools/giflib/giflib_5.2.1.bb
> similarity index 54%
> rename from meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb
> rename to meta-oe/recipes-devtools/giflib/giflib_5.2.1.bb
> index 1871bab46..cbb57782b 100644
> --- a/meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb
> +++ b/meta-oe/recipes-devtools/giflib/giflib_5.2.1.bb
> @@ -3,14 +3,18 @@ SECTION = "libs"
>   LICENSE = "MIT"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a"
>   
> -SRC_URI = " \
> -    ${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2 \
> -    file://CVE-2019-15133.patch \
> -"
> -
>   CVE_PRODUCT = "giflib_project:giflib"
>   
> -inherit autotools
> +DEPENDS = "xmlto-native"
> +
> +SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.gz"
> +SRC_URI[sha256sum] = "31da5562f44c5f15d63340a09a4fd62b48c45620cd302f77a6d9acf0077879bd"
> +
> +inherit autotools-brokensep
> +

do you know what broke out of tree builds ?

> +do_install() {
> +    oe_runmake DESTDIR=${D} PREFIX=${prefix} LIBDIR=${libdir} install
> +}
>   
>   PACKAGES += "${PN}-utils"
>   FILES_${PN} = "${libdir}/libgif.so.*"
> @@ -20,5 +24,4 @@ BBCLASSEXTEND = "native"
>   
>   RDEPENDS_${PN}-utils = "perl"
>   
> -SRC_URI[md5sum] = "2c171ced93c0e83bb09e6ccad8e3ba2b"
> -SRC_URI[sha256sum] = "df27ec3ff24671f80b29e6ab1c4971059c14ac3db95406884fc26574631ba8d5"
> +
> 
> 
> 
> 
> 