All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Scally <djrscally@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	jorhand@linux.microsoft.com, Tsuchiya Yuto <kitakar@gmail.com>
Subject: Re: cio2 ipu3 module to automatically connect sensors via swnodes
Date: Mon, 14 Sep 2020 16:08:57 +0100	[thread overview]
Message-ID: <49c6f074-9eca-4d47-a5dc-a4ea0cda0836@gmail.com> (raw)
In-Reply-To: <20200914145800.GF3956970@smile.fi.intel.com>

On 14/09/2020 15:58, Andy Shevchenko wrote:
> On Sat, Sep 12, 2020 at 08:45:10AM +0100, Dan Scally wrote:
>> Hello Heikki
>>
>> On 09/09/2020 14:40, Heikki Krogerus wrote:
>>> I'm almost certain that my graph patch is broken. My tests did not
>>> cover nearly as much that is needed to properly test the patch. I
>>> think at least the refcount handling is totally broken in
>>> software_node_graph_get_next_endpoint(), so that function at least
>>> needs to be rewritten.
>>>
>>> Unfortunately I do not have time to work on that patch right now.
>>>
>>> thanks,
>>
>> I managed to get to the bottom of the remaining issue (which was the cause
>> of the problem I originally posted here about - that's now all resolved).
>> In addition to the refcount handling problems,
>> software_node_graph_get_next_endpoint() was occasionally passing an invalid
>> combination of parameters to software_node_get_next_child(); sometimes it
>> would pass an existing endpoint as old in combination with a port which was
>> not the endpoint's parent. Applying this on top of your patch seems to stop
>> both of those errors:
> 
> Can you send a formal patch where you will be a co-developer to Heikki?
> Though I don't remember if Heikki signed off it.
> 

The original has his Signed-off-by on it yes, but it wasn't raised as a 
formal patch. I'll raise one and send it yes; probably tomorrow.

Thanks,
Dan

      reply	other threads:[~2020-09-14 17:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05  8:19 cio2 ipu3 module to automatically connect sensors via swnodes Daniel Scally
2020-09-07  9:44 ` Andy Shevchenko
2020-09-07 10:49   ` Kieran Bingham
2020-09-07 11:45     ` Dan Scally
2020-09-08  8:03 ` Sakari Ailus
2020-09-08  9:40   ` Dan Scally
2020-09-08 13:56     ` Andy Shevchenko
2020-09-09  9:29     ` Sakari Ailus
2020-09-09 13:40 ` Heikki Krogerus
2020-09-09 14:33   ` Dan Scally
2020-09-12  7:45   ` Dan Scally
2020-09-14 14:58     ` Andy Shevchenko
2020-09-14 15:08       ` Dan Scally [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49c6f074-9eca-4d47-a5dc-a4ea0cda0836@gmail.com \
    --to=djrscally@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jorhand@linux.microsoft.com \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=kitakar@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.