From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2180BC2BB85 for ; Wed, 15 Apr 2020 09:50:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E51CB206D9 for ; Wed, 15 Apr 2020 09:50:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=xen.org header.i=@xen.org header.b="Ft4P8P93" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E51CB206D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOeg6-0006xU-1C; Wed, 15 Apr 2020 09:49:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOeg4-0006xP-60 for xen-devel@lists.xenproject.org; Wed, 15 Apr 2020 09:49:52 +0000 X-Inumbo-ID: 739811f6-7efe-11ea-9e09-bc764e2007e4 Received: from mail.xenproject.org (unknown [104.130.215.37]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 739811f6-7efe-11ea-9e09-bc764e2007e4; Wed, 15 Apr 2020 09:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=u9uuE064Jb8xCh61RnjnOpdhmp/TBNWR/mKJf5x6p5Q=; b=Ft4P8P93LSORFtDNGdbVs94XSp D8zOtX5lmWewyw62cCnawg3KgNP1kH8NjRtPt9z0T3QQc6Z3N8iT7qT7OGFM58cQzk5Jl7ulU63b1 apLS4MLDbeAAwVIT8A9K7FDVP5ngNA4ODsvxyiWxTa7fmL9F5CNSvYPgnmfi7rh+L/Bs=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jOeg1-00080X-Hu; Wed, 15 Apr 2020 09:49:49 +0000 Received: from [54.239.6.177] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jOeg1-0007fp-A0; Wed, 15 Apr 2020 09:49:49 +0000 Subject: Re: [PATCH v2] Introduce a description of a new optional tag for Backports To: George Dunlap , Jan Beulich References: <20200410164942.9747-1-sstabellini@kernel.org> <50c8b3be-eadf-dd39-3ce0-05658faa3a4a@suse.com> <707a1448-be1d-0aa8-6b11-a33eb247304f@suse.com> <04881FC6-A816-44AB-8F25-54E5A265707E@citrix.com> From: Julien Grall Message-ID: <49c732e6-d30d-0892-0bd7-65c082da0429@xen.org> Date: Wed, 15 Apr 2020 10:49:47 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <04881FC6-A816-44AB-8F25-54E5A265707E@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Lars Kurth , Stefano Stabellini , "konrad.wilk@oracle.com" , Andrew Cooper , xen-devel , Stefano Stabellini Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 15/04/2020 10:43, George Dunlap wrote: > > >> On Apr 15, 2020, at 7:23 AM, Jan Beulich wrote: >> >> On 14.04.2020 18:54, Stefano Stabellini wrote: >>> On Tue, 14 Apr 2020, Jan Beulich wrote: >>>> On 10.04.2020 18:49, Stefano Stabellini wrote: >>> > [snip] >>>>> + Backport: all >>>>> + >>>>> +It marks a commit for being a candidate for backports to all relevant >>>>> +trees. >>>> >>>> I'm unconvinced of the utility of this form - what "all" resolves to >>>> changes over time. There's almost always a first version where a >>>> particular issue was introduced. If we want this to be generally >>>> useful, imo we shouldn't limit the scope of the tag to the upstream >>>> maintained stable trees. >>> >>> The reason why I suggested also to have a "wildcard" version of this >>> tag, is that the person adding the tag (could be the contributor trying >>> to be helpful) might not know exactly to which stable trees the patch >>> should be backported to. >>> >>> Writing this sentence, I realize that I really meant "any" rather than >>> "all". Would you prefer if I used "any"? Or we could even suggest to leave >>> it black like this: >>> >>> Backport: >>> >>> But it looks a bit weird. >> >> Indeed. Instead of "all" or "any", how about "yes", "unspecified", or >> "unknown"? Nevertheless, I still think people asking for a backport >> should be nudged towards determining the applicable range; them not >> doing so effectively pushes the burden to the general maintainers or >> the stable tree ones, both of which scales less well. Omitting the >> tag if they don't want to invest the time would to me then seem to >> be the cleanest alternative. Albeit I'm sure views here will vary. > > FWIW asking people adding the tag to do the work of figuring out which versions to backport to makes sense to me. If you ask the contributor to do the work then you need to give guidance on the "older" version you can specify in Backport. For instance, let say the bug was introduced in Xen 4.2. Are we allowing the user to specify Backport: 4.2+ or should it be 4.11+? I would favor the former as this helps for downstream user which haven't yet moved to the supported stable tree. Cheers, -- Julien Grall