From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A755C433F5 for ; Tue, 24 May 2022 14:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238197AbiEXObR (ORCPT ); Tue, 24 May 2022 10:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238224AbiEXObI (ORCPT ); Tue, 24 May 2022 10:31:08 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BF7E62FB for ; Tue, 24 May 2022 07:31:07 -0700 (PDT) Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4L6xRM08ZJz1JC6X; Tue, 24 May 2022 22:29:35 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 24 May 2022 22:31:04 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 24 May 2022 22:31:03 +0800 Message-ID: <49ca1cd8-e9a4-a76f-abae-d6204691665f@huawei.com> Date: Tue, 24 May 2022 22:31:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Content-Language: en-US To: Arnd Bergmann CC: kernel test robot , Catalin Marinas , Will Deacon , Andrew Morton , Linux ARM , Linux Kernel Mailing List , , Linux-MM , Christoph Hellwig , "Anshuman Khandual" References: <20220519082552.117736-5-wangkefeng.wang@huawei.com> <202205240657.BXxrhbgp-lkp@intel.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/5/24 20:35, Arnd Bergmann wrote: > On Tue, May 24, 2022 at 11:48 AM Kefeng Wang wrote: >>>>> mm/ioremap.c:59:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *addr @@ got void [noderef] __iomem *vaddr @@ >>> mm/ioremap.c:59:16: sparse: expected void const *addr >>> mm/ioremap.c:59:16: sparse: got void [noderef] __iomem *vaddr >>> >>> vim +59 mm/ioremap.c >>> >>> 51 >>> 52 void iounmap(volatile void __iomem *addr) >>> 53 { >>> 54 void __iomem *vaddr = (void __iomem *)((unsigned long)addr & PAGE_MASK); >>> 55 >>> 56 if (arch_iounmap(vaddr)) >>> 57 return; >>> 58 >>> > 59 vunmap(vaddr); >> 1) Will add generic "arch_ioremap/arch_iounmap define" >> >> 2) and change this to vunmap((void *)vaddr); > I think this need an extra __force to actually suppress the sparse > warning, as in > > vunmap((void __force *)vaddr); > > Using __force is usually wrong, this is one of the exceptions, so > maybe add a comment > as well. Right, I found this too， and  using  ___force in local, will update, thank. > > Arnd > > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FA4EC433F5 for ; Tue, 24 May 2022 14:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jgUw93SFq/wfBOWtJk+Cn5gU5uiEQsxo8ARWGK9a5jM=; b=ZQRdnDoLLw1Svg ysv235ebGpqurgXfOk4PHCxYuVRQ72mcOvdMyrv1KuNq0PK3u29UW9KJsebX303ho3zrN2KOg0zaw HBhLC+I+XUudQc1AkvVwCYE7wgf4N6zB9sRlHsoft2P1rOCuPQEnFl3HQbdtF7YxB4EPPK/Cw8Kkp OBfu6ar+VXumUNTCm/M9A0qmIzJw8eOdLqpqpgVWFeYvorWKC9g8tRjTcircaE/s66HOirYaNs6gw aZunffgVFtYFGl1qXbayK8POLpGWPsOQhpUJKVdu0SUfwium1i+BTkpcWtWLfx9SJNa3Bfs8gxdXw nrBZtkhXIMY+frNJvEQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntVZG-008G5X-Kh; Tue, 24 May 2022 14:31:26 +0000 Received: from szxga08-in.huawei.com ([45.249.212.255]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntVZ5-008FzY-DS for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 14:31:17 +0000 Received: from dggpemm500021.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4L6xRM08ZJz1JC6X; Tue, 24 May 2022 22:29:35 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 24 May 2022 22:31:04 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 24 May 2022 22:31:03 +0800 Message-ID: <49ca1cd8-e9a4-a76f-abae-d6204691665f@huawei.com> Date: Tue, 24 May 2022 22:31:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Content-Language: en-US To: Arnd Bergmann CC: kernel test robot , Catalin Marinas , Will Deacon , Andrew Morton , Linux ARM , Linux Kernel Mailing List , , Linux-MM , Christoph Hellwig , "Anshuman Khandual" References: <20220519082552.117736-5-wangkefeng.wang@huawei.com> <202205240657.BXxrhbgp-lkp@intel.com> From: Kefeng Wang In-Reply-To: X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_073115_718959_C8B98450 X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ck9uIDIwMjIvNS8yNCAyMDozNSwgQXJuZCBCZXJnbWFubiB3cm90ZToKPiBPbiBUdWUsIE1heSAy NCwgMjAyMiBhdCAxMTo0OCBBTSBLZWZlbmcgV2FuZyA8d2FuZ2tlZmVuZy53YW5nQGh1YXdlaS5j b20+IHdyb3RlOgo+Pj4+PiBtbS9pb3JlbWFwLmM6NTk6MTY6IHNwYXJzZTogc3BhcnNlOiBpbmNv cnJlY3QgdHlwZSBpbiBhcmd1bWVudCAxIChkaWZmZXJlbnQgYWRkcmVzcyBzcGFjZXMpIEBAICAg ICBleHBlY3RlZCB2b2lkIGNvbnN0ICphZGRyIEBAICAgICBnb3Qgdm9pZCBbbm9kZXJlZl0gX19p b21lbSAqdmFkZHIgQEAKPj4+ICAgICAgbW0vaW9yZW1hcC5jOjU5OjE2OiBzcGFyc2U6ICAgICBl eHBlY3RlZCB2b2lkIGNvbnN0ICphZGRyCj4+PiAgICAgIG1tL2lvcmVtYXAuYzo1OToxNjogc3Bh cnNlOiAgICAgZ290IHZvaWQgW25vZGVyZWZdIF9faW9tZW0gKnZhZGRyCj4+Pgo+Pj4gdmltICs1 OSBtbS9pb3JlbWFwLmMKPj4+Cj4+PiAgICAgICA1MQo+Pj4gICAgICAgNTIgICAgICAgdm9pZCBp b3VubWFwKHZvbGF0aWxlIHZvaWQgX19pb21lbSAqYWRkcikKPj4+ICAgICAgIDUzICAgICAgIHsK Pj4+ICAgICAgIDU0ICAgICAgICAgICAgICAgdm9pZCBfX2lvbWVtICp2YWRkciA9ICh2b2lkIF9f aW9tZW0gKikoKHVuc2lnbmVkIGxvbmcpYWRkciAmIFBBR0VfTUFTSyk7Cj4+PiAgICAgICA1NQo+ Pj4gICAgICAgNTYgICAgICAgICAgICAgICBpZiAoYXJjaF9pb3VubWFwKHZhZGRyKSkKPj4+ICAg ICAgIDU3ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm47Cj4+PiAgICAgICA1OAo+Pj4gICAg ID4gNTkgICAgICAgICAgICAgICB2dW5tYXAodmFkZHIpOwo+PiAxKSBXaWxsIGFkZCBnZW5lcmlj ICJhcmNoX2lvcmVtYXAvYXJjaF9pb3VubWFwIGRlZmluZSIKPj4KPj4gMikgYW5kIGNoYW5nZSB0 aGlzIHRvIHZ1bm1hcCgodm9pZCAqKXZhZGRyKTsKPiBJIHRoaW5rIHRoaXMgbmVlZCBhbiBleHRy YSBfX2ZvcmNlIHRvIGFjdHVhbGx5IHN1cHByZXNzIHRoZSBzcGFyc2UKPiB3YXJuaW5nLCBhcyBp bgo+Cj4gICAgICAgICAgdnVubWFwKCh2b2lkIF9fZm9yY2UgKil2YWRkcik7Cj4KPiBVc2luZyBf X2ZvcmNlIGlzIHVzdWFsbHkgd3JvbmcsIHRoaXMgaXMgb25lIG9mIHRoZSBleGNlcHRpb25zLCBz bwo+IG1heWJlIGFkZCBhIGNvbW1lbnQKPiBhcyB3ZWxsLgpSaWdodCwgSSBmb3VuZCB0aGlzIHRv b++8jCBhbmTCoCB1c2luZ8KgIF9fX2ZvcmNlIGluIGxvY2FsLCB3aWxsIHVwZGF0ZSwgdGhhbmsu Cj4KPiAgICAgICAgICAgQXJuZAo+Cj4gLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4727055340617635341==" MIME-Version: 1.0 From: Kefeng Wang To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() Date: Tue, 24 May 2022 22:31:03 +0800 Message-ID: <49ca1cd8-e9a4-a76f-abae-d6204691665f@huawei.com> In-Reply-To: List-Id: --===============4727055340617635341== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 2022/5/24 20:35, Arnd Bergmann wrote: > On Tue, May 24, 2022 at 11:48 AM Kefeng Wang wrote: >>>>> mm/ioremap.c:59:16: sparse: sparse: incorrect type in argument 1 (dif= ferent address spaces) @@ expected void const *addr @@ got void [no= deref] __iomem *vaddr @@ >>> mm/ioremap.c:59:16: sparse: expected void const *addr >>> mm/ioremap.c:59:16: sparse: got void [noderef] __iomem *vaddr >>> >>> vim +59 mm/ioremap.c >>> >>> 51 >>> 52 void iounmap(volatile void __iomem *addr) >>> 53 { >>> 54 void __iomem *vaddr =3D (void __iomem *)((unsign= ed long)addr & PAGE_MASK); >>> 55 >>> 56 if (arch_iounmap(vaddr)) >>> 57 return; >>> 58 >>> > 59 vunmap(vaddr); >> 1) Will add generic "arch_ioremap/arch_iounmap define" >> >> 2) and change this to vunmap((void *)vaddr); > I think this need an extra __force to actually suppress the sparse > warning, as in > > vunmap((void __force *)vaddr); > > Using __force is usually wrong, this is one of the exceptions, so > maybe add a comment > as well. Right, I found this too=EF=BC=8C and=C2=A0 using=C2=A0 ___force in local, w= ill update, thank. > > Arnd > > . --===============4727055340617635341==--