From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F820C433FE for ; Fri, 25 Nov 2022 02:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbiKYCwA (ORCPT ); Thu, 24 Nov 2022 21:52:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbiKYCv7 (ORCPT ); Thu, 24 Nov 2022 21:51:59 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7317C29C81; Thu, 24 Nov 2022 18:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=WWyZ4GfuqQwjnEiGPBNjGmerSmAHeGHS1FWRjctLS5c=; b=ONIED5KAuazuCFSe5Sv0J83SAk Z1iPtr0dD0YKb331mx7x9CgRUzUgCJzUeSmvnL+XbyfKasT7W195Q4Ni+6ssuUNKirP5Nhxfmhg+Y UGSK77Nn0O69nLnHTMMuGvB4HV41EVE9RLPxr6CTtiK78WSCJ/8i4DBnoHIE1WIy+5THJMgPtgQ1k cf31CG8JdBJjeIb1B6QKhvOKxZhz1YUVrrLHRN7O7q+nc0EiSIkA1AzmgTw0ctAZsRxnhTOQkyNb8 OY8VOqgF8Uuon+Mru4Pw1R+2J+jevU5D9fg6qxqN5P9fM0/uV0QGFJoDExRS2NkfzBUd0e9gzpkF2 +sGj9JmA==; Received: from [2601:1c2:d80:3110::a2e7] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyOoi-00CI53-3Q; Fri, 25 Nov 2022 02:51:52 +0000 Message-ID: <49d0555b-7bd3-f8c7-f9ff-683d9720c6c7@infradead.org> Date: Thu, 24 Nov 2022 18:51:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] fs: namei: fix two excess parameter description warnings Content-Language: en-US To: Kushagra Verma , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/22 04:28, Kushagra Verma wrote: > While building the kernel documentation, two excess parameter description > warnings appear: > ./fs/namei.c:3589: warning: Excess function parameter 'dentry' > description in 'vfs_tmpfile' > ./fs/namei.c:3589: warning: Excess function parameter 'open_flag' > description in 'vfs_tmpfile' > > Fix these warnings by changing 'dentry' to 'parentpath' in the parameter > description and 'open_flag' to 'file' and change 'file' parameter's > description accordingly. > > Signed-off-by: Kushagra Verma Tested-by: Randy Dunlap Thanks. > --- > fs/namei.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/namei.c b/fs/namei.c > index 578c2110df02..8e77e194fed5 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -3571,9 +3571,9 @@ static int do_open(struct nameidata *nd, > /** > * vfs_tmpfile - create tmpfile > * @mnt_userns: user namespace of the mount the inode was found from > - * @dentry: pointer to dentry of the base directory > + * @parentpath: pointer to dentry of the base directory > * @mode: mode of the new tmpfile > - * @open_flag: flags > + * @file: file information > * > * Create a temporary file. > * -- ~Randy