From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BD8C433FE for ; Tue, 4 Oct 2022 15:05:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbiJDPFU (ORCPT ); Tue, 4 Oct 2022 11:05:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbiJDPFQ (ORCPT ); Tue, 4 Oct 2022 11:05:16 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E72D51416 for ; Tue, 4 Oct 2022 08:05:14 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id o7so14282817lfk.7 for ; Tue, 04 Oct 2022 08:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=v9qAcpY/EulrMR7IHMzcNeWHI6LbF7pg8NXAg+ErSDmILTlVv9VuATHeiDFUuS0GDk fMPUpg+ZIm2fvpOjwhU0jNrO51zTdX5Wo89TE4EpRBM2U6EglD08H2D49MIHAr+WLhko QutFGm6gKSaXJOgqQqp0VLMjpvhTVkSYKRXOY7lsbEpK7hpvEMVYv/IOjeuYVy2lpDuy RIbwA4QZi5UsdDLDWczQYuAqCNJVPlYdCGswtZoaf03Nol5+mrQy953CxoP1IFoIOrTU nFaOMmcYVh/vGEvNaZPxeKoSDLmFz2Hx+xOXxbVYjjLs1Y6XZTdt5PUigU9+DBfhOe6G ScPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=CE074thcClqgZWj640B5vyg9km7IzPVsGF2DfpVGIOQU1sdpiyCAsYWTiNG87zCmNJ Zmb3EmqfE9nroU5LRc+bJnyQdqFdLQLKXSaGTj8fjHg2u0lDw3FHt1EmnnpwVKZtuEls sF8CazpXHBazTTR8ZtFzh4zzsgPxR8qigXYIL1FesstlOm+HbDTGnotAGZdUXW7MsPQ1 2+IfzH42pflWpSuFmm3ixiEoHOYQ6wSoq3h/uKV5AD0sJKedBWcbukCKBqQ4OJC1pSSL sPER26MzfpRiNAjuumFW/myEnusBcIbXBcReKHI55aIi5/5wpuvr+KHVFPysfwFyGXg8 d2nw== X-Gm-Message-State: ACrzQf0zdFujYNI13a7xfCKzWKB1g9Vf7dGnRfV74CKxAJoWpy4Oi14Q jzFoVsFNMsVzDMP8KvkzvOU5RQ== X-Google-Smtp-Source: AMsMyM4AtZAJOWtGqNYNncGG28gDj+M6F6V0yMuWIAJhpHtFLCOUuhev79xS5vLvDH12H9Ljm6wesQ== X-Received: by 2002:a19:6909:0:b0:4a2:5d5a:2f49 with SMTP id e9-20020a196909000000b004a25d5a2f49mr430421lfc.66.1664895912921; Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a16-20020a19f810000000b00494643db68fsm1952030lff.81.2022.10.04.08.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Message-ID: <49daae86-e922-9a17-ebed-2a33a5eeb18e@linaro.org> Date: Tue, 4 Oct 2022 17:05:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2022 13:55, Guillaume Ranquet wrote: >> No. You said what the code is doing. I think I understand this. You >> still do not need more compatibles. Your sentence did not clarify it >> because it did not answer at all to question "why". Why do you need it? >> >> Sorry, the change looks not correct. >> >> Best regards, >> Krzysztof >> > > I need a new compatible to adress the specifics of mt8195 in the mtk_dpi driver, > the change is in this series with: > [PATCH v1 16/17] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver [1] But you do not have specifics of mt8195. I wrote it in the beginning. > > I then need to add that compatible to the "list" here in mtk_drm_drv. No, you do not... I checked the driver and there is no single need... or convince me you need. > I don't see a way around this unless I rewrite the way mtk_drm_drv works? Why rewrite? You have all compatibles in place. > > Maybe if I declare a new compatible that is generic to all mediatek > dpi variants? You were asked to use fallback. Don't create some fake fallbacks. Use existing ones. > and have all the dts specify the node with both the generic dpi and > the specific compatible? > > dpi@xxx { > compatible = "mediatek,dpi", "mediatek,mt8195-dpi"; I don't know what's this but certainly looks odd. Some wild-card compatible in front (not fallback) and none are documented. > ... > } > > Then I can "collapse" all the dpi related nodes in mtk_drm_drv under > "mediatek,dpi" ? > > I guess would have to do the change for all other components that are needed in > mtk_drm_drv (mmsys, aal, ccor, color, dither, dsc, gamma, mutex...). > > That's the only trivial way I can think of implementing this with the > current status > of the mtk_drm stack. > > Do you have any other ideas in mind? Use fallback of compatible device. That's the common pattern. Everywhere, Mediatek as well. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 654D0C4332F for ; Tue, 4 Oct 2022 15:05:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63EDC10E3AC; Tue, 4 Oct 2022 15:05:18 +0000 (UTC) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8B0210E2B7 for ; Tue, 4 Oct 2022 15:05:14 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id z4so21564305lft.2 for ; Tue, 04 Oct 2022 08:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=v9qAcpY/EulrMR7IHMzcNeWHI6LbF7pg8NXAg+ErSDmILTlVv9VuATHeiDFUuS0GDk fMPUpg+ZIm2fvpOjwhU0jNrO51zTdX5Wo89TE4EpRBM2U6EglD08H2D49MIHAr+WLhko QutFGm6gKSaXJOgqQqp0VLMjpvhTVkSYKRXOY7lsbEpK7hpvEMVYv/IOjeuYVy2lpDuy RIbwA4QZi5UsdDLDWczQYuAqCNJVPlYdCGswtZoaf03Nol5+mrQy953CxoP1IFoIOrTU nFaOMmcYVh/vGEvNaZPxeKoSDLmFz2Hx+xOXxbVYjjLs1Y6XZTdt5PUigU9+DBfhOe6G ScPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=kbMoOWYl/XN3dH7bQk8EmqkQEFpFRjEskwYuMBTCxugieUiabf4qvymvoJ0nPhmkcG xr32mdfAQ656506px4Z2+lqxH6QqasG4JL7DoVV5i+E+JWZ/kSbGgqih1q0WyMrGCKlm hKV5Yl2DFjPKFlqdphEOAFbI3Y6HSxtwRRAoIE1VSQzIgoUR+cwXu6KQ3rc/uJ2j8Ww4 iqIHfMFn66V6flZT52qn8ATJIQte80ZuLtt70FiVwOLIjp+FyG6SR9e19hUsvVdaW9Ye HZslIjY1uzwimxv+vCIupDWe/glkJarbAHcOJ7ppAe9YOsNZdAk4dqTV6BI7qsB3QpNC S2Cw== X-Gm-Message-State: ACrzQf0XerGG9g0LlZ1PoPT8aiDebLX4pHT2SAAQPgQ30YX7Gwrl1PEZ v5B01nlPMvBBEnwF5/2NxpHITw== X-Google-Smtp-Source: AMsMyM4AtZAJOWtGqNYNncGG28gDj+M6F6V0yMuWIAJhpHtFLCOUuhev79xS5vLvDH12H9Ljm6wesQ== X-Received: by 2002:a19:6909:0:b0:4a2:5d5a:2f49 with SMTP id e9-20020a196909000000b004a25d5a2f49mr430421lfc.66.1664895912921; Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a16-20020a19f810000000b00494643db68fsm1952030lff.81.2022.10.04.08.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Message-ID: <49daae86-e922-9a17-ebed-2a33a5eeb18e@linaro.org> Date: Tue, 4 Oct 2022 17:05:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Mattijs Korpershoek , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, Pablo Sun , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 04/10/2022 13:55, Guillaume Ranquet wrote: >> No. You said what the code is doing. I think I understand this. You >> still do not need more compatibles. Your sentence did not clarify it >> because it did not answer at all to question "why". Why do you need it? >> >> Sorry, the change looks not correct. >> >> Best regards, >> Krzysztof >> > > I need a new compatible to adress the specifics of mt8195 in the mtk_dpi driver, > the change is in this series with: > [PATCH v1 16/17] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver [1] But you do not have specifics of mt8195. I wrote it in the beginning. > > I then need to add that compatible to the "list" here in mtk_drm_drv. No, you do not... I checked the driver and there is no single need... or convince me you need. > I don't see a way around this unless I rewrite the way mtk_drm_drv works? Why rewrite? You have all compatibles in place. > > Maybe if I declare a new compatible that is generic to all mediatek > dpi variants? You were asked to use fallback. Don't create some fake fallbacks. Use existing ones. > and have all the dts specify the node with both the generic dpi and > the specific compatible? > > dpi@xxx { > compatible = "mediatek,dpi", "mediatek,mt8195-dpi"; I don't know what's this but certainly looks odd. Some wild-card compatible in front (not fallback) and none are documented. > ... > } > > Then I can "collapse" all the dpi related nodes in mtk_drm_drv under > "mediatek,dpi" ? > > I guess would have to do the change for all other components that are needed in > mtk_drm_drv (mmsys, aal, ccor, color, dither, dsc, gamma, mutex...). > > That's the only trivial way I can think of implementing this with the > current status > of the mtk_drm stack. > > Do you have any other ideas in mind? Use fallback of compatible device. That's the common pattern. Everywhere, Mediatek as well. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ACCBC433FE for ; Tue, 4 Oct 2022 15:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=upfsi5p3qnjZ+drdQWhYfPILzAbIjantcMludiYIbNU=; b=A3DqVWV76qbThU yH7Irx+6Dsww4SzSjGkeplWWsDME1BS9vF8hpFroiYRR2XvJ/MK4hn2b8P5CoMG7QR4lSHcbV2+hJ UpL7KYHP6zx8K1Mvk+1cOJNMoBut7PRO/OxGPbRjX/a28ACjIxRgjf0OgkC3F/GOjikc36ksfboL7 uIUMDQxHlXYg5+a4toTRGo8eenv214ftJ+R6AcmH5TYiAFVSZKZq99nN3qIRl2mKiNE7WbwiAmvbo L7nCHxDZg2HI91VccZGb5nnom6WdRLwSZ1gPO9k5lr5H6dDPlHMiy/C0/g5+EyVUlB074NchZXsJL lPqUoN2iLpS4MFhsdilg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofjU7-009zZ6-7z; Tue, 04 Oct 2022 15:05:27 +0000 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofjTx-009zVY-Jp for linux-phy@lists.infradead.org; Tue, 04 Oct 2022 15:05:18 +0000 Received: by mail-lf1-x12a.google.com with SMTP id s20so5881555lfi.11 for ; Tue, 04 Oct 2022 08:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=v9qAcpY/EulrMR7IHMzcNeWHI6LbF7pg8NXAg+ErSDmILTlVv9VuATHeiDFUuS0GDk fMPUpg+ZIm2fvpOjwhU0jNrO51zTdX5Wo89TE4EpRBM2U6EglD08H2D49MIHAr+WLhko QutFGm6gKSaXJOgqQqp0VLMjpvhTVkSYKRXOY7lsbEpK7hpvEMVYv/IOjeuYVy2lpDuy RIbwA4QZi5UsdDLDWczQYuAqCNJVPlYdCGswtZoaf03Nol5+mrQy953CxoP1IFoIOrTU nFaOMmcYVh/vGEvNaZPxeKoSDLmFz2Hx+xOXxbVYjjLs1Y6XZTdt5PUigU9+DBfhOe6G ScPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=b6x/pj0kdj9Zm/TZLxhNL9pAyHwo4vqfjXIxa04+NHu+Bcqd1Dci+3wXj+oXT2l4kN 1CdVb0Z0ovVvKmiq/e6NyYEUdHavGoxuIIlmU/T6o5J8Xrua+D6ubKMbCfmXinN/DkTk QpG1aqXajsDYswLqgGQJct1W5j4Ship86QK9M/uH5Zzjj73R993EJe95MrGbpyWnaRVI fGhZOcmg/eki2mrjTgRmjp3x0BMMs4M7VZx1StOaTKpxZISkgAKttkQ61//U59VR6MTk gfInItdG0I33o99uo61jYjiODOhwQjaHIPO0LLVdN3mD12PtwCs5TRDXmfBy0ngo4g8u nmPg== X-Gm-Message-State: ACrzQf3a/O/0+0zQ6gVFkK9t7IWjZqTAAML9av3Tax5C1LfzbmTSFWSa Yz66EjYcUwli+QnX0kQOxjT1cA== X-Google-Smtp-Source: AMsMyM4AtZAJOWtGqNYNncGG28gDj+M6F6V0yMuWIAJhpHtFLCOUuhev79xS5vLvDH12H9Ljm6wesQ== X-Received: by 2002:a19:6909:0:b0:4a2:5d5a:2f49 with SMTP id e9-20020a196909000000b004a25d5a2f49mr430421lfc.66.1664895912921; Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a16-20020a19f810000000b00494643db68fsm1952030lff.81.2022.10.04.08.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Message-ID: <49daae86-e922-9a17-ebed-2a33a5eeb18e@linaro.org> Date: Tue, 4 Oct 2022 17:05:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_080517_660889_2EAE83A0 X-CRM114-Status: GOOD ( 22.28 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 04/10/2022 13:55, Guillaume Ranquet wrote: >> No. You said what the code is doing. I think I understand this. You >> still do not need more compatibles. Your sentence did not clarify it >> because it did not answer at all to question "why". Why do you need it? >> >> Sorry, the change looks not correct. >> >> Best regards, >> Krzysztof >> > > I need a new compatible to adress the specifics of mt8195 in the mtk_dpi driver, > the change is in this series with: > [PATCH v1 16/17] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver [1] But you do not have specifics of mt8195. I wrote it in the beginning. > > I then need to add that compatible to the "list" here in mtk_drm_drv. No, you do not... I checked the driver and there is no single need... or convince me you need. > I don't see a way around this unless I rewrite the way mtk_drm_drv works? Why rewrite? You have all compatibles in place. > > Maybe if I declare a new compatible that is generic to all mediatek > dpi variants? You were asked to use fallback. Don't create some fake fallbacks. Use existing ones. > and have all the dts specify the node with both the generic dpi and > the specific compatible? > > dpi@xxx { > compatible = "mediatek,dpi", "mediatek,mt8195-dpi"; I don't know what's this but certainly looks odd. Some wild-card compatible in front (not fallback) and none are documented. > ... > } > > Then I can "collapse" all the dpi related nodes in mtk_drm_drv under > "mediatek,dpi" ? > > I guess would have to do the change for all other components that are needed in > mtk_drm_drv (mmsys, aal, ccor, color, dither, dsc, gamma, mutex...). > > That's the only trivial way I can think of implementing this with the > current status > of the mtk_drm stack. > > Do you have any other ideas in mind? Use fallback of compatible device. That's the common pattern. Everywhere, Mediatek as well. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30659C433FE for ; Tue, 4 Oct 2022 15:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+gpTk5p0Pcad5omEJ3yV1RrUVgUf/p5jJoh4Rtyinag=; b=pZGbzhEMgL37dG o+MboWWlmdSRAPchZl4zHxVwUG09jlpV4P5sxU7k9I1QGA51Y7m1/h1qQ9OnXUd+UnOjfCLhT7JqK P8VVB2g3MPbRs8tOHlQspY58eeolUIpLipW/S3LnnaOlCY/KFeWCaiBpct1R92XOTcD+olKfF7IgJ 8MgCzHkVa2BtDP3Z/vPla99s0LDmkwS1P0EfY4Nj9VG7j4W48GChVGU/M3yv+5w9IE4K7VRgBPWTJ whQdTjcST0vtgI3cxo3zESIIJPLvng5ARx5yer28LJblYAYaMV8TS919SFiJ9vvVnXhyL3nAf8sYU kdvphDGV35mhlNehCNcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofjTz-009zWg-49; Tue, 04 Oct 2022 15:05:19 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofjTv-009zVX-T8 for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 15:05:17 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 25so11279184lft.9 for ; Tue, 04 Oct 2022 08:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=v9qAcpY/EulrMR7IHMzcNeWHI6LbF7pg8NXAg+ErSDmILTlVv9VuATHeiDFUuS0GDk fMPUpg+ZIm2fvpOjwhU0jNrO51zTdX5Wo89TE4EpRBM2U6EglD08H2D49MIHAr+WLhko QutFGm6gKSaXJOgqQqp0VLMjpvhTVkSYKRXOY7lsbEpK7hpvEMVYv/IOjeuYVy2lpDuy RIbwA4QZi5UsdDLDWczQYuAqCNJVPlYdCGswtZoaf03Nol5+mrQy953CxoP1IFoIOrTU nFaOMmcYVh/vGEvNaZPxeKoSDLmFz2Hx+xOXxbVYjjLs1Y6XZTdt5PUigU9+DBfhOe6G ScPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CWdX4tvEDe9KXAQIvWXUpR26N6THyFmklq+pYn7/wck=; b=NvJDGJKZKivDEjaWfQyNOX69mREa328bCSqlO+J3TT9fuQxewOd4+6/gdoZGFIRsjx YdNs9ZQ2TgFkdiSm6PGZhAZzxPeVR//7jIDR/A2XZJyc2C3U+2ibEjXNx3D7VC3jD9kn N9Y2p09sh4INcWQyanZJxByknt0APZVcR4kVowl4Hk5PITWutLxux0q+MgxSB1dxrw2v hVm4zWZZQFmxn7ojdrqCpFkZ3Isv/Ghv6NGTVh4jGTPBYkNbhjIC1lVwosDMOhQ7C3Q/ KIc+FZx2ZjtuLeJhQrcQd85S0SqdgKYTlAH11XVMqqjEvDu7PEekECsStXg/Zlw9/zSz n1Lw== X-Gm-Message-State: ACrzQf1WFQ/4h1rnN6sZarSK0hN+SKj+/6W1ZrQTTPnQymz//Q6bVlWg r5TH++sSPW56hsVhGmTGfnh8qA== X-Google-Smtp-Source: AMsMyM4AtZAJOWtGqNYNncGG28gDj+M6F6V0yMuWIAJhpHtFLCOUuhev79xS5vLvDH12H9Ljm6wesQ== X-Received: by 2002:a19:6909:0:b0:4a2:5d5a:2f49 with SMTP id e9-20020a196909000000b004a25d5a2f49mr430421lfc.66.1664895912921; Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a16-20020a19f810000000b00494643db68fsm1952030lff.81.2022.10.04.08.05.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 08:05:12 -0700 (PDT) Message-ID: <49daae86-e922-9a17-ebed-2a33a5eeb18e@linaro.org> Date: Tue, 4 Oct 2022 17:05:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 17/17] drm/mediatek: Add mt8195-dpi support to drm_drv Content-Language: en-US To: Guillaume Ranquet , Michael Turquette , Kishon Vijay Abraham I , Matthias Brugger , Vinod Koul , Stephen Boyd , David Airlie , Rob Herring , Philipp Zabel , Krzysztof Kozlowski , Daniel Vetter , Chunfeng Yun , CK Hu , Jitao shi , Chun-Kuang Hu Cc: linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Pablo Sun , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mattijs Korpershoek , linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20220919-v1-0-4844816c9808@baylibre.com> <20220919-v1-17-4844816c9808@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_080515_948587_F1A2C945 X-CRM114-Status: GOOD ( 23.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/10/2022 13:55, Guillaume Ranquet wrote: >> No. You said what the code is doing. I think I understand this. You >> still do not need more compatibles. Your sentence did not clarify it >> because it did not answer at all to question "why". Why do you need it? >> >> Sorry, the change looks not correct. >> >> Best regards, >> Krzysztof >> > > I need a new compatible to adress the specifics of mt8195 in the mtk_dpi driver, > the change is in this series with: > [PATCH v1 16/17] drm/mediatek: dpi: Add mt8195 hdmi to DPI driver [1] But you do not have specifics of mt8195. I wrote it in the beginning. > > I then need to add that compatible to the "list" here in mtk_drm_drv. No, you do not... I checked the driver and there is no single need... or convince me you need. > I don't see a way around this unless I rewrite the way mtk_drm_drv works? Why rewrite? You have all compatibles in place. > > Maybe if I declare a new compatible that is generic to all mediatek > dpi variants? You were asked to use fallback. Don't create some fake fallbacks. Use existing ones. > and have all the dts specify the node with both the generic dpi and > the specific compatible? > > dpi@xxx { > compatible = "mediatek,dpi", "mediatek,mt8195-dpi"; I don't know what's this but certainly looks odd. Some wild-card compatible in front (not fallback) and none are documented. > ... > } > > Then I can "collapse" all the dpi related nodes in mtk_drm_drv under > "mediatek,dpi" ? > > I guess would have to do the change for all other components that are needed in > mtk_drm_drv (mmsys, aal, ccor, color, dither, dsc, gamma, mutex...). > > That's the only trivial way I can think of implementing this with the > current status > of the mtk_drm stack. > > Do you have any other ideas in mind? Use fallback of compatible device. That's the common pattern. Everywhere, Mediatek as well. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel