From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 029E6C19F29 for ; Thu, 28 Jul 2022 08:32:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234532AbiG1Icd (ORCPT ); Thu, 28 Jul 2022 04:32:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234351AbiG1Icc (ORCPT ); Thu, 28 Jul 2022 04:32:32 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE2655F996 for ; Thu, 28 Jul 2022 01:32:27 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id q23so1819637lfr.3 for ; Thu, 28 Jul 2022 01:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hI2m9NPPZwjaeUAdv/OUDYJH2jCwotQ6GbUvku4Sz58=; b=eZdNWRmQOtaqbNQMyzuIC5DQa7hLZLvmFxlylaAYGkdiXMSUev4ygletmQSIAzWlKN P7zdd/nvDHynGU5Bz9kuAxcqhlOKnFsV9wqC7tB7aMRVHRKv/ZBOLvr/oQQ9W9tTrwKD E+Rvs+VZzIyVnXeC98gQDmDRLULQD52PwjxYR+R70MngNebqr81q82HA0S9MqWhVmIIP KroZ+DBjQVoc2SKLFtCgGj1utg8B0Q1pLeyDdxXTGKg6wix7YZmrH9JXXoAuFEzpWeP2 Af3+oTj70SzmahTNwqCtMEPxoReEhcT9EjbiIdJMsztcx0xfoVt9oBvV6qak1GlvxcXF Dwfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hI2m9NPPZwjaeUAdv/OUDYJH2jCwotQ6GbUvku4Sz58=; b=3xqSmGxQLrF92U3F1Cu6ASg9nM0bfaksOoiNfmgD/So+U8gRw403O2xiUSlRx+H5OG T6LhVtIhcji2WW7GyQgmrqNoOJcDwMgobWET5cpWNfNuhiiOWbI2NiPmTsvl85xGsJ5N 9vyBQi2AQN18tH9kotxvW7+L6IGKCDNsdrk6Nd0xKI6kvUaXV692c/2wjARHA/lHt9eg S4Hw0SasOFqIj7u1WzPraF/32LigYj6XTDIm6lcLYLYl77VYr2/2BsVIBpuNd/t4UyKm QKkYsaAK0btC16Ewz/kDXXAlid7Zh7O74lgWctAP+uFB8Sxbu5/N35MXGADQ0fsKBPHC PUzg== X-Gm-Message-State: AJIora/ChJndAGtI4XvVAQXA8zQwwQs1DLt/ifG5KMcNE7LjDipc6h7v ARMUC7JQnLoGJ98lfAZG4h2d2w== X-Google-Smtp-Source: AGRyM1tNGhUok0FkmEJmPyrmh3QNCxe5DcCV7R3sFLucoHlfS1pQj7W+hsJlBnkTL3BBMpcSN/uxgQ== X-Received: by 2002:ac2:5317:0:b0:48a:7227:5223 with SMTP id c23-20020ac25317000000b0048a72275223mr10107964lfh.376.1658997145937; Thu, 28 Jul 2022 01:32:25 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id t12-20020a19dc0c000000b0047f84ecae2esm86865lfg.236.2022.07.28.01.32.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 01:32:25 -0700 (PDT) Message-ID: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> Date: Thu, 28 Jul 2022 10:32:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US To: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> From: Krzysztof Kozlowski In-Reply-To: <20220727013349.3056826-1-saravanak@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 27/07/2022 03:33, Saravana Kannan wrote: > As soon as a gpio is registered, it should be usable by a consumer. So, > do all the initialization before registering the gpios. Without this > change, a consumer can request a GPIO IRQ and have the gpio to IRQ > mapping fail. > > Signed-off-by: Saravana Kannan Looks good. Linus, It's too late for me to pick it up, so make you could grab it directly? Reviewed-by: Krzysztof Kozlowski Otherwise it will wait for merge window to finish. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A43A5C04A68 for ; Thu, 28 Jul 2022 08:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=laRYLIv2zatZSytD9sFD25Pl+rPLzOSQmOyJIgnduZA=; b=rlDfd5fLCX0xTv ALovj+Y2dCmMPEw1DBF3IBNaV0fwNZty4JUduivhQQgCzDgKFkjweEYBAji0f1bT7521By0OzcFhK AihX3mB550Kcaq3oAWpylbkPRBgY4DEJasXa7NkrZ34KXbDWKaytBkSfxdOlC/xMP2NnsbsVWcD7A i6Klo53oDQulQAEkFuXtaQiCipNbS/f4DryPmA0jnIWRSTzNjAefEpjHwM6WxcYL4ulqxLoScrcNh HWT8oPwPz482L1sYPglCT+MYrJsbwxnuvX33on3MCLiXbK8okPQ3tKTT96OJkBQUdgwiNvt9jxsbi gMShqo1nRroUSp166zIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGywb-005ovu-0l; Thu, 28 Jul 2022 08:32:33 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGywY-005ot0-1r for linux-arm-kernel@lists.infradead.org; Thu, 28 Jul 2022 08:32:31 +0000 Received: by mail-lf1-x12e.google.com with SMTP id z25so1825522lfr.2 for ; Thu, 28 Jul 2022 01:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hI2m9NPPZwjaeUAdv/OUDYJH2jCwotQ6GbUvku4Sz58=; b=eZdNWRmQOtaqbNQMyzuIC5DQa7hLZLvmFxlylaAYGkdiXMSUev4ygletmQSIAzWlKN P7zdd/nvDHynGU5Bz9kuAxcqhlOKnFsV9wqC7tB7aMRVHRKv/ZBOLvr/oQQ9W9tTrwKD E+Rvs+VZzIyVnXeC98gQDmDRLULQD52PwjxYR+R70MngNebqr81q82HA0S9MqWhVmIIP KroZ+DBjQVoc2SKLFtCgGj1utg8B0Q1pLeyDdxXTGKg6wix7YZmrH9JXXoAuFEzpWeP2 Af3+oTj70SzmahTNwqCtMEPxoReEhcT9EjbiIdJMsztcx0xfoVt9oBvV6qak1GlvxcXF Dwfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hI2m9NPPZwjaeUAdv/OUDYJH2jCwotQ6GbUvku4Sz58=; b=fYpyEpix3JGe3ZUQkEKb4bPTFKfviCwqDGZvb9gFzaAuV8uC6pn3qaYUD8rrl+bNRH EwznOHzmSKohyEps3vEvDlnpodIXY6oBg2fXZhDiJCn/SXeJNo0n/Mo8fqlXK/tDrLMP au2aJXdceYaezsl+CFogmlrbmWZH3ChrU8Yl+K84Zz+NAEYdwBXYycCvoMReK4DQMASI snMcHS8orVPzwslGAqu7C7JgGgXpSaGu2jMdRZg0Jwe5U7jp9I3sRECjt1wtJJhjtVBd VahHqSqSH8ZM8GG4GQBt8EuiIDdXY13uMDkomjV4jPfwJ0L6NXWRrO8O2Dwnm5n8vNlW LS+g== X-Gm-Message-State: AJIora9Or8QD/A6DKpstID1UOuTE/EwbuVpJADy2Htg2kBKCsEs8jmqS If8VPLk+vxbUyh6ZIX/zd+zZjA== X-Google-Smtp-Source: AGRyM1tNGhUok0FkmEJmPyrmh3QNCxe5DcCV7R3sFLucoHlfS1pQj7W+hsJlBnkTL3BBMpcSN/uxgQ== X-Received: by 2002:ac2:5317:0:b0:48a:7227:5223 with SMTP id c23-20020ac25317000000b0048a72275223mr10107964lfh.376.1658997145937; Thu, 28 Jul 2022 01:32:25 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id t12-20020a19dc0c000000b0047f84ecae2esm86865lfg.236.2022.07.28.01.32.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 01:32:25 -0700 (PDT) Message-ID: <49e4f45a-51da-ec4c-9ebb-dfa022bf8a88@linaro.org> Date: Thu, 28 Jul 2022 10:32:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v1] pinctrl: samsung: Finish initializing the gpios before registering them Content-Language: en-US To: Saravana Kannan , Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , Linus Walleij Cc: kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220727013349.3056826-1-saravanak@google.com> From: Krzysztof Kozlowski In-Reply-To: <20220727013349.3056826-1-saravanak@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220728_013230_128379_8718EAA8 X-CRM114-Status: UNSURE ( 8.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/07/2022 03:33, Saravana Kannan wrote: > As soon as a gpio is registered, it should be usable by a consumer. So, > do all the initialization before registering the gpios. Without this > change, a consumer can request a GPIO IRQ and have the gpio to IRQ > mapping fail. > > Signed-off-by: Saravana Kannan Looks good. Linus, It's too late for me to pick it up, so make you could grab it directly? Reviewed-by: Krzysztof Kozlowski Otherwise it will wait for merge window to finish. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel