From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24373C433FE for ; Tue, 9 Nov 2021 14:39:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05309611F0 for ; Tue, 9 Nov 2021 14:39:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238254AbhKIOlw (ORCPT ); Tue, 9 Nov 2021 09:41:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231136AbhKIOlv (ORCPT ); Tue, 9 Nov 2021 09:41:51 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E79DC061764; Tue, 9 Nov 2021 06:39:05 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id f3so44811789lfu.12; Tue, 09 Nov 2021 06:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=jyBJ2upKfJG7Kux4hCZeboSUewwZJRYpFMsj9SS8i9o=; b=ir5ZDcmf7V95JKIIyYhgBklVQc51+WQK0AbUSVRDTddSpZDY7m/Sdbo9aPJ5NYWLf+ I/o4DyC5wZ6xRt6JKdXdtjf4Hm0fOaqxmKfhws9a2RMAIq1+/0aSn2cB3dZy+UVn5ox6 cpX9RnQPtJlHN1f9wDaRfjiL5jdg32z40OqHS5yVyiz0pDXDZSx9pYNl7548NroN1cni Ix6R4pk2i8q8ZSsli6vqOG9FqiDZvPAs1El8MCGqtNAsmG0mFJX5vcJlqPCsfAxQl+rm Gu06YXzR1SA/wdJKMK2OcAjPyYKHwprgEbRczrWdgmC7vvGjTsHBywepZDQac7hAusbu wvAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jyBJ2upKfJG7Kux4hCZeboSUewwZJRYpFMsj9SS8i9o=; b=4kYNJ9+FpRehVSHrwo8heWBbFMkZzeOr7GzMUv7B9KY0OvJIhpmwBsAExr9N/wNj3j S/iWaci62dJ+ePMowa00a4ofW50GnJglr/bGvGLiajIO3c/SGQL/O/O+CNbQxIn5K1iT g9p3wDzC1ECXIxmQnLWBNq1Uy60DRbn8+6evib02Q56hZQ+iypzXmQf0k65bDKXzGxTg unI4ZMfv7PcoO0/tomRZxbLH4gD1pYzKt8R0LCKKLuO4jgZGtTpjrVNnGUAZNTLnutxX DmnGRAeHOYaBLjjhXIozOFHzqguxkeVB6vi45yzbT2PK9NFkoGIMzz16tI2bWRZ5dDZi BhoA== X-Gm-Message-State: AOAM5311/6Ieub6JkDnw0wCPDrQkFn8nkchTK2wSE0zX4YJySGFLdbXL dRshLIueOdu6riG3MlRnwDUf7qK4viQ= X-Google-Smtp-Source: ABdhPJznlfY8+zh/8oMdgnpOTLoYcyynyD4lHaDCdiihjw2hT3YhH1pFxJnm3shxUvURStovH+KaCA== X-Received: by 2002:a05:6512:152a:: with SMTP id bq42mr7278741lfb.109.1636468743544; Tue, 09 Nov 2021 06:39:03 -0800 (PST) Received: from [192.168.2.145] (79-139-188-96.dynamic.spd-mgts.ru. [79.139.188.96]) by smtp.googlemail.com with ESMTPSA id i18sm2154335lfv.147.2021.11.09.06.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 06:39:03 -0800 (PST) Subject: Re: [PATCH v1 2/2] drm/tegra: Use drm_dp_aux_register_ddc/chardev() helpers From: Dmitry Osipenko To: Thierry Reding , Jonathan Hunter , Lyude Paul , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Thomas Graichen , dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211107230821.13511-1-digetx@gmail.com> <20211107230821.13511-2-digetx@gmail.com> <0a2c02ae-3fe1-e384-28d3-13e13801d675@gmail.com> <857a48ae-9ff4-89fe-11ce-5f1573763941@gmail.com> <71fcbc09-5b60-ee76-49b2-94adc965eda5@gmail.com> Message-ID: <49ffd29b-eb64-e0ca-410c-44074673d740@gmail.com> Date: Tue, 9 Nov 2021 17:39:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <71fcbc09-5b60-ee76-49b2-94adc965eda5@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 09.11.2021 17:17, Dmitry Osipenko пишет: > 09.11.2021 17:08, Dmitry Osipenko пишет: >>> +static void host1x_drm_dev_deinit(struct host1x_device *dev) >>> +{ >>> + struct drm_device *drm = dev_get_drvdata(&dev->dev); >> And platform_unregister_drivers() should be moved here. >> > > Nah, that should cause deadlock. This ad-hoc is too lame. Actually, there is no problem here as I see now. The host1x driver populates DT nodes after host1x_register() [1], meaning that Host1x DRM will be always inited first. [1] https://elixir.bootlin.com/linux/v5.15/source/drivers/gpu/host1x/dev.c#L475 Still I'm not a fan of the ad-hoc solution. > Another solution is to defer probing of DP AUX driver while > tegra_drm_device() returns NULL, but it's icky. > > Reverting the original DP AUX DDC registration order is the best option > so far, IMO. >