All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Vladimir Ivashchenko <hazard@francoudi.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
	Eric Dumazet <dada1@cosmosbay.com>,
	netdev@vger.kernel.org
Subject: Re: bond + tc regression ?
Date: Wed, 06 May 2009 15:31:06 +0200	[thread overview]
Message-ID: <4A01911A.1090709@trash.net> (raw)
In-Reply-To: <20090506131117.GA10105@francoudi.com>

Vladimir Ivashchenko wrote:
> On Wed, May 06, 2009 at 10:48:08AM +0000, Jarek Poplawski wrote:
> 
>>>>>> ifconfig -a
>>>>> bond0     Link encap:Ethernet  HWaddr 00:1B:24:BD:E9:CC
>>>>>           inet addr:xxx.xxx.135.44  Bcast:xxx.xxx.135.47  Mask:255.255.255.248
>>>>>           inet6 addr: fe80::21b:24ff:febd:e9cc/64 Scope:Link
>>>>>           UP BROADCAST RUNNING MASTER MULTICAST  MTU:1500  Metric:1
>>>>>           RX packets:436076190 errors:0 dropped:391250 overruns:0 frame:0
>>>>>           TX packets:2620156321 errors:0 dropped:0 overruns:0 carrier:0
>>>>>           collisions:0 txqueuelen:0
>>>>>           RX bytes:4210046233 (3.9 GiB)  TX bytes:2520272242 (2.3 GiB)
>>>> Could you try e.g.: ifconfig bond0 txqueuelen 1000
>>>> before tc qdisc add?
>>> The drops on ifconfig are not increasing - these numbers are there from some tests made
>>> before.
>>>
>> I'm not sure what do you mean? IMHO you don't use qdiscs properly,
>> so any TX problems end with drops. (Older kernel versions could mask
>> this problem with requeuing.)
> 
> Apologies, my bad, I misread what you wrote.
> 
> txqueuelen 1000 fixes the qdisc drops. I didn't notice that bond interfaces have it set to 0 by default.

The fifos use a queue length of 1 when the tx_queue_len is zero (which
was added as a workaround for similar problems a long time ago). Perhaps
we should instead refuse these broken configurations or at least print
a warning.

      reply	other threads:[~2009-05-06 13:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 15:45 bond + tc regression ? Vladimir Ivashchenko
2009-05-05 16:25 ` Denys Fedoryschenko
2009-05-05 16:31 ` Eric Dumazet
2009-05-05 17:41   ` Vladimir Ivashchenko
2009-05-05 18:50     ` Eric Dumazet
2009-05-05 23:50       ` Vladimir Ivashchenko
2009-05-05 23:52         ` Stephen Hemminger
2009-05-06  3:36         ` Eric Dumazet
2009-05-06 10:28           ` Vladimir Ivashchenko
2009-05-06 10:41             ` Eric Dumazet
2009-05-06 10:49               ` Denys Fedoryschenko
2009-05-06 18:45           ` Vladimir Ivashchenko
2009-05-06 19:30             ` Denys Fedoryschenko
2009-05-06 20:47               ` Vladimir Ivashchenko
2009-05-06 21:46                 ` Denys Fedoryschenko
2009-05-08 20:46                   ` Vladimir Ivashchenko
2009-05-08 21:05                     ` Denys Fedoryschenko
2009-05-08 22:07                       ` Vladimir Ivashchenko
2009-05-08 22:42                         ` Denys Fedoryschenko
2009-05-17 18:46                           ` Vladimir Ivashchenko
2009-05-18  8:51                             ` Jarek Poplawski
2009-05-06  8:03       ` Ingo Molnar
2009-05-06  6:10     ` Jarek Poplawski
2009-05-06 10:36       ` Vladimir Ivashchenko
2009-05-06 10:48         ` Jarek Poplawski
2009-05-06 13:11           ` Vladimir Ivashchenko
2009-05-06 13:31             ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A01911A.1090709@trash.net \
    --to=kaber@trash.net \
    --cc=dada1@cosmosbay.com \
    --cc=hazard@francoudi.com \
    --cc=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.