From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 1/4] qemu: external module: smp_send_reschedule compat Date: Thu, 07 May 2009 16:28:20 +0300 Message-ID: <4A02E1F4.9050906@redhat.com> References: <20090427210740.675732111@amt.cnet> <20090427210839.980307693@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, sheng@linux.intel.com To: mtosatti@redhat.com Return-path: Received: from mx2.redhat.com ([66.187.237.31]:35225 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756910AbZEGN2W (ORCPT ); Thu, 7 May 2009 09:28:22 -0400 In-Reply-To: <20090427210839.980307693@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: mtosatti@redhat.com wrote: > smp_send_reschedule was exported (via smp_ops) in v2.6.24. > Create a compat function which schedules the IPI to keventd context, > in case interrupts are disabled, for kernels < 2.6.24. > > > #endif > > +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,28) > +#define nr_cpu_ids NR_CPUS > +#endif > + > Doesn't seem related? Please send as a separate patch. > diff --git a/kvm/kernel/x86/hack-module.awk b/kvm/kernel/x86/hack-module.awk > index 260eeef..f4d14da 100644 > --- a/kvm/kernel/x86/hack-module.awk > +++ b/kvm/kernel/x86/hack-module.awk > @@ -35,6 +35,8 @@ BEGIN { split("INIT_WORK desc_struct ldttss_desc64 desc_ptr " \ > > { sub(/match->dev->msi_enabled/, "kvm_pcidev_msi_enabled(match->dev)") } > > +{ sub(/smp_send_reschedule/, "kvm_smp_send_reschedule") } > + > /^static void __vmx_load_host_state/ { > vmx_load_host_state = 1 > } > > There's a bit on the top of hack-module.awk that does this slightly simpler. Please also adjust ia64. This now resides in kvm-kmod.git, please patch against that. -- error compiling committee.c: too many arguments to function