From: Jeff Garzik <jeff@garzik.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
viro@zeniv.linux.org.uk,
Andrew Morton <akpm@linux-foundation.org>,
roland@redhat.com
Subject: Re: [PATCH 1/2 v2] kernel/{sched,smp}.c: fix static decl prior to struct declaration
Date: Mon, 11 May 2009 16:06:06 -0400 [thread overview]
Message-ID: <4A08852E.4010504@garzik.org> (raw)
In-Reply-To: <20090511112648.GA27226@elte.hu>
Ingo Molnar wrote:
> -tip testing found this build bug:
>
> kernel/sched.c: In function ‘root_task_group_empty’:
> kernel/sched.c:312: error: ‘root_task_group’ undeclared (first use in this function)
> kernel/sched.c:312: error: (Each undeclared identifier is reported only once
> kernel/sched.c:312: error: for each function it appears in.)
>
> config attached.
Fixed and resent.
What a rat's nest of ifdefs! root_task_group is outside
CONFIG_USER_SCHED, and so I kept that property in patch v3.
However, its definition in kernel/sched.h is conditional on
CONFIG_USER_SCHED, even though root_task_group_empty() may exist outside
of CONFIG_USER_SCHED, and root_task_group is referenced vi
CONFIG_FAIR_GROUP_SCHED || CONFIG_RT_GROUP_SCHED.
Starting to wish I had never patched this code in the first place (that
barb is directed at the code, not you...)
Jeff
next prev parent reply other threads:[~2009-05-11 20:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-08 18:48 [PATCH 1/2] kernel/{sched,smp}.c: fix static decl prior to struct declaration Jeff Garzik
2009-05-08 18:50 ` [RFC PATCH 2/2] kernel/sched.c: VLA in middle of struct Jeff Garzik
2009-05-08 19:09 ` Ingo Molnar
2009-05-10 8:49 ` Rusty Russell
2009-05-10 15:09 ` Jeff Garzik
2009-05-12 13:34 ` Rusty Russell
2009-05-12 14:03 ` Al Viro
2009-05-13 2:12 ` Rusty Russell
2009-05-13 2:31 ` Jeff Garzik
2009-05-13 5:36 ` Al Viro
2009-05-13 6:49 ` [PATCH] sched: avoid flexible array member inside struct (gcc extension) Rusty Russell
2009-05-13 13:51 ` [tip:sched/urgent] " tip-bot for Rusty Russell
2009-05-11 10:58 ` [RFC PATCH 2/2] kernel/sched.c: VLA in middle of struct Ingo Molnar
2009-05-11 20:43 ` Jeff Garzik
2009-05-11 20:49 ` Ingo Molnar
2009-05-12 2:24 ` Jeff Garzik
2009-05-12 8:54 ` Ingo Molnar
2009-05-08 19:04 ` [PATCH 1/2] kernel/{sched,smp}.c: fix static decl prior to struct declaration Ingo Molnar
2009-05-08 19:08 ` Jeff Garzik
2009-05-08 19:13 ` Ingo Molnar
2009-05-08 19:38 ` [PATCH 1/2 v2] " Jeff Garzik
2009-05-11 11:26 ` Ingo Molnar
2009-05-11 20:06 ` Jeff Garzik [this message]
2009-05-11 20:51 ` Ingo Molnar
2009-05-11 11:30 ` [tip:sched/core] kernel/{sched, smp}.c: " tip-bot for Jeff Garzik
2009-05-11 20:02 ` [PATCH 1/2 v3] kernel/{sched,smp}.c: " Jeff Garzik
2009-05-11 21:51 ` [tip:sched/urgent] kernel/{sched, smp}.c: " tip-bot for Jeff Garzik
2009-05-11 21:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A08852E.4010504@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.