From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756762AbZEMFwT (ORCPT ); Wed, 13 May 2009 01:52:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752040AbZEMFwH (ORCPT ); Wed, 13 May 2009 01:52:07 -0400 Received: from iona.labri.fr ([147.210.8.143]:35261 "EHLO iona.labri.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbZEMFwG (ORCPT ); Wed, 13 May 2009 01:52:06 -0400 Message-ID: <4A0A600F.9010801@inria.fr> Date: Wed, 13 May 2009 07:52:15 +0200 From: Brice Goglin User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: Christoph Lameter , linux-mm@kvack.org, LKML , Andrew Morton Subject: Re: [PATCH] migration: only migrate_prep() once per move_pages() References: <49E58D7A.4010708@ens-lyon.org> <20090415164955.41746866.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090415164955.41746866.kamezawa.hiroyu@jp.fujitsu.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org KAMEZAWA Hiroyuki wrote: > On Wed, 15 Apr 2009 09:32:10 +0200 > Brice Goglin wrote: > > >> migrate_prep() is fairly expensive (72us on 16-core barcelona 1.9GHz). >> Commit 3140a2273009c01c27d316f35ab76a37e105fdd8 improved move_pages() >> throughput by breaking it into chunks, but it also made migrate_prep() >> be called once per chunk (every 128pages or so) instead of once per >> move_pages(). >> >> This patch reverts to calling migrate_prep() only once per chunk >> as we did before 2.6.29. >> It is also a followup to commit 0aedadf91a70a11c4a3e7c7d99b21e5528af8d5d >> mm: move migrate_prep out from under mmap_sem >> >> This improves migration throughput on the above machine from 600MB/s >> to 750MB/s. >> >> Signed-off-by: Brice Goglin >> >> > Reviewed-by: KAMEZAWA Hiroyuki > > I think this patch is good. page migration is best-effort syscall ;) > Since nobody complained about this patch, may I get a Ack and get the patch merged for 2.6.31? thanks, Brice From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 40C2B6B00C2 for ; Wed, 13 May 2009 01:51:20 -0400 (EDT) Message-ID: <4A0A600F.9010801@inria.fr> Date: Wed, 13 May 2009 07:52:15 +0200 From: Brice Goglin MIME-Version: 1.0 Subject: Re: [PATCH] migration: only migrate_prep() once per move_pages() References: <49E58D7A.4010708@ens-lyon.org> <20090415164955.41746866.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20090415164955.41746866.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Christoph Lameter , linux-mm@kvack.org, LKML , Andrew Morton List-ID: KAMEZAWA Hiroyuki wrote: > On Wed, 15 Apr 2009 09:32:10 +0200 > Brice Goglin wrote: > > >> migrate_prep() is fairly expensive (72us on 16-core barcelona 1.9GHz). >> Commit 3140a2273009c01c27d316f35ab76a37e105fdd8 improved move_pages() >> throughput by breaking it into chunks, but it also made migrate_prep() >> be called once per chunk (every 128pages or so) instead of once per >> move_pages(). >> >> This patch reverts to calling migrate_prep() only once per chunk >> as we did before 2.6.29. >> It is also a followup to commit 0aedadf91a70a11c4a3e7c7d99b21e5528af8d5d >> mm: move migrate_prep out from under mmap_sem >> >> This improves migration throughput on the above machine from 600MB/s >> to 750MB/s. >> >> Signed-off-by: Brice Goglin >> >> > Reviewed-by: KAMEZAWA Hiroyuki > > I think this patch is good. page migration is best-effort syscall ;) > Since nobody complained about this patch, may I get a Ack and get the patch merged for 2.6.31? thanks, Brice -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org