From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Enable dirty logging for all regions during migration Date: Wed, 13 May 2009 10:00:05 +0300 Message-ID: <4A0A6FF5.8050708@redhat.com> References: <1242170654-8685-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, ehabkost@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:36741 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbZEMHAh (ORCPT ); Wed, 13 May 2009 03:00:37 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4D70cRc022383 for ; Wed, 13 May 2009 03:00:38 -0400 In-Reply-To: <1242170654-8685-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Glauber Costa wrote: > From: Glauber de Oliveira Costa > > In current calculations, we are not activating dirty logging > for all regions, leading migration to fail. This problem was > already raised by Yaniv Kamay a while ago. The proposed > solution at the time (not merged), was a calculation to convert > from target_phys_addr_t to ram_addr_t, which the dirty logging code > expects. > > Avi noticed that enabling dirty logging for the region 0 -> -1ULL > would do the trick. As I hit the problem, I can confirm it does. > > This patch, therefore, goes with this simpler approach. Before > this patch, migration fails. With this patch, simple migration > tests succeds. > > Applied, thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.