All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Jeff King <peff@peff.net>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
	Caleb Cushing <xenoterracide@gmail.com>,
	git@vger.kernel.org
Subject: Re: git push origin error (1.6.3 new default functionality)
Date: Wed, 13 May 2009 11:54:20 +0200	[thread overview]
Message-ID: <4A0A98CC.2090701@drmicha.warpmail.net> (raw)
In-Reply-To: <20090513090317.GA3421@sigill.intra.peff.net>

Jeff King venit, vidit, dixit 13.05.2009 11:03:
> On Wed, May 13, 2009 at 10:44:33AM +0200, Johannes Sixt wrote:
> 
>> Unfortunately, the case with this warning is not that "simple" because it
>> is not about a planned change of the default behavior, but about a default
>> behavior that may be unexpected for newbies (see the release notes of
>> 1.6.3). I *can* understand that Caleb is upset by the warning, since he's
>> comfortable with the (current and future) default behavior. But I don't
>> know what to do in cases like these.
> 
> I thought this was in preparation for an eventual change, but I might be
> wrong (1.6.3 introduced several such warnings).
> 
> Regardless, my point was: the warning was introduced for a purpose
> (either to point out potentially confusing behavior, or to warn the user
> about an upcoming change in default behavior). Showing up now and saying
> "I don't like this warning" without addressing any of the points in the
> original discussion or making any sort of proposal to try to accomplish
> the same goals is just counterproductive.

I don't want to stir this up to much again - as I said, set config and
be done.

My main issue is the fact that we have a config variable (push.default)
which causes a different behaviour depending on whether it is unset or
set to its default (!) value. That is a completely new UI approach. We
may follow through with this for a "beginners' mode" for git, where
commands with possibly unintended side effects issue warnings, as
opposed to an "advanced mode" (activated by 1 config variable) which
shuts these off. Right now this new behaviour is isolated and feels strange.

Michael

  reply	other threads:[~2009-05-13  9:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12  1:26 git push origin error (1.6.3 new default functionality) Caleb Cushing
2009-05-12 11:11 ` Michael J Gruber
2009-05-13  5:26   ` Caleb Cushing
2009-05-13  8:32     ` Jeff King
2009-05-13  8:44       ` Johannes Sixt
2009-05-13  9:03         ` Jeff King
2009-05-13  9:54           ` Michael J Gruber [this message]
2009-05-14  6:31             ` Jeff King
2009-05-14  7:37               ` Michael J Gruber
2009-05-13 18:37   ` Junio C Hamano
2009-05-14  3:30     ` Caleb Cushing
2009-05-14  4:44       ` Junio C Hamano
2009-05-14  5:29         ` Junio C Hamano
2009-05-14  8:57           ` Finn Arne Gangstad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0A98CC.2090701@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=peff@peff.net \
    --cc=xenoterracide@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.