From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533AbZEUJbY (ORCPT ); Thu, 21 May 2009 05:31:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752063AbZEUJbP (ORCPT ); Thu, 21 May 2009 05:31:15 -0400 Received: from hera.kernel.org ([140.211.167.34]:36078 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbZEUJbO (ORCPT ); Thu, 21 May 2009 05:31:14 -0400 Message-ID: <4A151F59.7020304@kernel.org> Date: Thu, 21 May 2009 18:31:05 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH 15/20] sysfs: Kill sysfs_addrm_start and sysfs_addrm_finish References: <1242865694-2100-1-git-send-email-ebiederm@xmission.com> <1242865694-2100-2-git-send-email-ebiederm@xmission.com> <1242865694-2100-3-git-send-email-ebiederm@xmission.com> <1242865694-2100-4-git-send-email-ebiederm@xmission.com> <1242865694-2100-5-git-send-email-ebiederm@xmission.com> <1242865694-2100-6-git-send-email-ebiederm@xmission.com> <1242865694-2100-7-git-send-email-ebiederm@xmission.com> <1242865694-2100-8-git-send-email-ebiederm@xmission.com> <1242865694-2100-9-git-send-email-ebiederm@xmission.com> <1242865694-2100-10-git-send-email-ebiederm@xmission.com> <1242865694-2100-11-git-send-email-ebiederm@xmission.com> <1242865694-2100-12-git-send-email-ebiederm@xmission.com> <1242865694-2100-13-git-send-email-ebiederm@xmission.com> <1242865694-2100-14-git-send-email-ebiederm@xmission.com> <1242865694-2100-15-git-send-email-ebiederm@xmission.com> In-Reply-To: <1242865694-2100-15-git-send-email-ebiederm@xmission.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Thu, 21 May 2009 09:31:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > From: Eric W. Biederman > > With lazy inode updates and dentry operations bringing everything > into sync on demand there is no longer any need to immediately > update the vfs or grab i_mutex to protect those updates as we > make changes to sysfs. > > So stop updating the vfs inodes and move what remains of > sysfs_addrm_start and sysfs_addrm_finsih (just barely more than taking > the sysfs_mutex) into sysfs_add_one and sysfs_remove_one. > > Signed-off-by: Eric W. Biederman This looks so better than the original code. :-) Acked-by: Tejun Heo -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 15/20] sysfs: Kill sysfs_addrm_start and sysfs_addrm_finish Date: Thu, 21 May 2009 18:31:05 +0900 Message-ID: <4A151F59.7020304@kernel.org> References: <1242865694-2100-1-git-send-email-ebiederm@xmission.com> <1242865694-2100-2-git-send-email-ebiederm@xmission.com> <1242865694-2100-3-git-send-email-ebiederm@xmission.com> <1242865694-2100-4-git-send-email-ebiederm@xmission.com> <1242865694-2100-5-git-send-email-ebiederm@xmission.com> <1242865694-2100-6-git-send-email-ebiederm@xmission.com> <1242865694-2100-7-git-send-email-ebiederm@xmission.com> <1242865694-2100-8-git-send-email-ebiederm@xmission.com> <1242865694-2100-9-git-send-email-ebiederm@xmission.com> <1242865694-2100-10-git-send-email-ebiederm@xmission.com> <1242865694-2100-11-git-send-email-ebiederm@xmission.com> <1242865694-2100-12-git-send-email-ebiederm@xmission.com> <1242865694-2100-13-git-send-email-ebiederm@xmission.com> <1242865 694-2100-14-git-send-email-ebiederm@xmission.com> <1242865694-2100-15-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" To: "Eric W. Biederman" Return-path: Received: from hera.kernel.org ([140.211.167.34]:36078 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750815AbZEUJbO (ORCPT ); Thu, 21 May 2009 05:31:14 -0400 In-Reply-To: <1242865694-2100-15-git-send-email-ebiederm@xmission.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Eric W. Biederman wrote: > From: Eric W. Biederman > > With lazy inode updates and dentry operations bringing everything > into sync on demand there is no longer any need to immediately > update the vfs or grab i_mutex to protect those updates as we > make changes to sysfs. > > So stop updating the vfs inodes and move what remains of > sysfs_addrm_start and sysfs_addrm_finsih (just barely more than taking > the sysfs_mutex) into sysfs_add_one and sysfs_remove_one. > > Signed-off-by: Eric W. Biederman This looks so better than the original code. :-) Acked-by: Tejun Heo -- tejun