From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MA2vr-0003c8-HX
	for qemu-devel@nongnu.org; Fri, 29 May 2009 10:19:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MA2vl-0003ZK-RG
	for qemu-devel@nongnu.org; Fri, 29 May 2009 10:19:38 -0400
Received: from [199.232.76.173] (port=40113 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MA2vk-0003Yr-LT
	for qemu-devel@nongnu.org; Fri, 29 May 2009 10:19:33 -0400
Received: from gecko.sbs.de ([194.138.37.40]:16335)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1MA2vj-00022g-8S
	for qemu-devel@nongnu.org; Fri, 29 May 2009 10:19:31 -0400
Message-ID: <4A1FEEED.3090804@siemens.com>
Date: Fri, 29 May 2009 16:19:25 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp
	parameters and -net channel
References: <20090508103416.6080.44298.stgit@mchn012c.ww002.siemens.net>
	<20090508103418.6080.96654.stgit@mchn012c.ww002.siemens.net>
	<1243523221.4046.195.camel@blaa>
	<200905291242.27869.paul@codesourcery.com>
In-Reply-To: <200905291242.27869.paul@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org

Paul Brook wrote:
>>> +extern char tftp_prefix[PATH_MAX];
>>> +extern char bootp_filename[PATH_MAX];
>> This wouldn't build for me without including limits.h here
> 
> It still won't work. You can't assume PATH_MAX is defined at all.
> 

You are right, one cannot always assume its there, but we already do:

block.c:    char tmp_filename[PATH_MAX];
block.c:    char backing_filename[PATH_MAX];
qemu-char.c:    char pty_name[PATH_MAX];
...

So there must be a way to make all platforms happy qemu builds against.
Otherwise I wouldn't have used it in the first place.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux