From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753323AbZFEU4Z (ORCPT ); Fri, 5 Jun 2009 16:56:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752153AbZFEU4S (ORCPT ); Fri, 5 Jun 2009 16:56:18 -0400 Received: from terminus.zytor.com ([198.137.202.10]:45470 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752001AbZFEU4R (ORCPT ); Fri, 5 Jun 2009 16:56:17 -0400 Message-ID: <4A29862D.6030601@zytor.com> Date: Fri, 05 Jun 2009 13:55:09 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Jaswinder Singh Rajput CC: Andrew Morton , Ingo Molnar , x86 maintainers , LKML Subject: Re: [PATCH -tip] x86: cpu/proc.c adding extended_cpuid_level for /proc/cpuinfo References: <1242112482.3283.1.camel@localhost.localdomain> <20090512232122.61f2d7c5.akpm@linux-foundation.org> <1244227115.2507.3.camel@ht.satnam> In-Reply-To: <1244227115.2507.3.camel@ht.satnam> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaswinder Singh Rajput wrote: > Hello Andrew, > > On Tue, 2009-05-12 at 23:21 -0700, Andrew Morton wrote: >> On Tue, 12 May 2009 12:44:42 +0530 Jaswinder Singh Rajput wrote: >> >>> + "ext cpuid level\t: 0x%x\n" >> It's unobvious what "ext" means. External? >> >> Can we make it "extended cpuid level"? > > extended cpuid level will look like this : > > fpu : yes > fpu_exception : yes > cpuid level : 5 > wp : yes > extended cpuid level: 0x80000008 > flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe constant_tsc pebs bts pni dtes64 monitor ds_cpl cid > The more I'm thinking about this I think it was a mistake to put cpuid level: there in the first place, too. My opinion is increasingly to leave this to x86info or other user-space tools. -hpa