From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gui Jianfeng Subject: Re: [PATCH 08/18] io-controller: idle for sometime on sync queue before expiring it Date: Tue, 09 Jun 2009 15:56:38 +0800 Message-ID: <4A2E15B6.8030001__16759.187114849$1244534451$gmane$org@cn.fujitsu.com> References: <1241553525-28095-1-git-send-email-vgoyal@redhat.com> <1241553525-28095-9-git-send-email-vgoyal@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1241553525-28095-9-git-send-email-vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Vivek Goyal Cc: dhaval-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, snitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jens.axboe-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, paolo.valente-rcYM44yAMweonA0d6jMUrA@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org, jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, fchecconi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, righi.andrea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: containers.vger.kernel.org Vivek Goyal wrote: ... > +ssize_t elv_fairness_store(struct request_queue *q, const char *name, > + size_t count) > +{ > + struct elv_fq_data *efqd; > + unsigned int data; > + unsigned long flags; > + > + char *p = (char *)name; > + > + data = simple_strtoul(p, &p, 10); > + > + if (data < 0) > + data = 0; > + else if (data > INT_MAX) > + data = INT_MAX; Hi Vivek, data might overflow on 64 bit systems. In addition, since "fairness" is nothing more than a switch, just let it be. Signed-off-by: Gui Jianfeng --- block/elevator-fq.c | 10 +++++----- block/elevator-fq.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/elevator-fq.c b/block/elevator-fq.c index 655162b..42d4279 100644 --- a/block/elevator-fq.c +++ b/block/elevator-fq.c @@ -2605,7 +2605,7 @@ static inline int is_root_group_ioq(struct request_queue *q, ssize_t elv_fairness_show(struct request_queue *q, char *name) { struct elv_fq_data *efqd; - unsigned int data; + unsigned long data; unsigned long flags; spin_lock_irqsave(q->queue_lock, flags); @@ -2619,17 +2619,17 @@ ssize_t elv_fairness_store(struct request_queue *q, const char *name, size_t count) { struct elv_fq_data *efqd; - unsigned int data; + unsigned long data; unsigned long flags; char *p = (char *)name; data = simple_strtoul(p, &p, 10); - if (data < 0) + if (!data) data = 0; - else if (data > INT_MAX) - data = INT_MAX; + else + data = 1; spin_lock_irqsave(q->queue_lock, flags); efqd = &q->elevator->efqd; diff --git a/block/elevator-fq.h b/block/elevator-fq.h index b2bb11a..4fe843a 100644 --- a/block/elevator-fq.h +++ b/block/elevator-fq.h @@ -359,7 +359,7 @@ struct elv_fq_data { * throughput and focus more on providing fairness for sync * queues. */ - int fairness; + unsigned long fairness; }; extern int elv_slice_idle; -- 1.5.4.rc3