From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 10 Jun 2009 19:48:36 +0200 Subject: [U-Boot] [PATCH 3/4] ZOOM2 Add power reset button In-Reply-To: <1244638432-30893-4-git-send-email-Tom.Rix@windriver.com> References: <1244638432-30893-1-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-2-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-3-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-4-git-send-email-Tom.Rix@windriver.com> Message-ID: <4A2FF1F4.5010805@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Tom, Tom Rix wrote: > The power reset button is on the top right side of the main board. > Press and hold for about to 8 seconds to completely reset the board. > > Some of the beta boards have a hardware problem that prevents > using this feature. If is difficult to further characterize the > boards that fail. So disable resetting for all beta boards. > > Signed-off-by: Tom Rix > --- > board/omap3/zoom2/zoom2.c | 13 +++++++++++++ > drivers/i2c/twl4030_i2c.c | 22 ++++++++++++++++++++++ > include/configs/omap3_zoom2.h | 1 + > include/twl4030.h | 10 ++++++++++ > 4 files changed, 46 insertions(+), 0 deletions(-) > > diff --git a/board/omap3/zoom2/zoom2.c b/board/omap3/zoom2/zoom2.c > index 08fdafb..d5da920 100644 > --- a/board/omap3/zoom2/zoom2.c > +++ b/board/omap3/zoom2/zoom2.c [...] > diff --git a/drivers/i2c/twl4030_i2c.c b/drivers/i2c/twl4030_i2c.c > index 774f813..549f974 100644 > --- a/drivers/i2c/twl4030_i2c.c > +++ b/drivers/i2c/twl4030_i2c.c > @@ -35,3 +35,25 @@ static inline int twl4030_i2c_read_u8(u8 chip_no, u8 *val, u8 reg) > return i2c_read(chip_no, reg, 1, val, 1); > } > > +/* > + * Power Reset > + */ > +void twl4030_power_reset_init(void) > +{ What has this to do with an i2c driver? No, I don;t want to see such a function in an i2c driver. I tend to put this "driver" in an another dir, like I said in my previous mail maybe in drivers/misc ... bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany