From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Date: Wed, 10 Jun 2009 19:59:17 +0200 Subject: [U-Boot] [PATCH 2/4] I2C Add initial support for TWL4030 In-Reply-To: <7A436F7769CA33409C6B44B358BFFF0C0115C326A3@dlee02.ent.ti.com> References: <1244638432-30893-1-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-2-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-3-git-send-email-Tom.Rix@windriver.com> <7A436F7769CA33409C6B44B358BFFF0C0115C326A3@dlee02.ent.ti.com> Message-ID: <4A2FF475.3010406@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Menon, Menon, Nishanth wrote: >> -----Original Message----- >> From: Tom Rix [mailto:Tom.Rix at windriver.com] >> Sent: Wednesday, June 10, 2009 7:54 AM >> To: u-boot at lists.denx.de >> Cc: dirk.behme at googlemail.com; Menon, Nishanth; Tom Rix >> Subject: [PATCH 2/4] I2C Add initial support for TWL4030 >> >> --- >> drivers/i2c/Makefile | 1 + >> drivers/i2c/twl4030_i2c.c | 37 ++++++++ >> include/twl4030.h | 221 > This is an interesting area -> in kernel we used to have i2c/busses and i2c/chips -> u-boot has drivers/i2c which probably is equivalent to i2c/busses -> should we create subdirectories there? In the current form, this driver does not fit into drivers/i2c if I am not wrong.. No, I think it is not necessary here to create subdirs in "drivers/i2c". This driver should go in "drivers/power" ... bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany