All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Beth Kon <eak@us.ibm.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 5/5] HPET interaction with in-kernel PIT (v6)
Date: Sun, 14 Jun 2009 12:35:09 +0300	[thread overview]
Message-ID: <4A34C44D.8020803@redhat.com> (raw)
In-Reply-To: <4A34C261.5000908@web.de>

Jan Kiszka wrote:
> Unfortunate. But on the one hand, nothing technically prevents defining
> the IOCTL base on existing kvm_pit_state, but passing down extended
> kvm_pit_state2 if that negotiation took place. On the other hand, we are
> not yet running out of IOCTL numbers...
>   

Right, and we are not in any competition for most obfuscated interface 
yet (though we'd probably get an honourable mention if we were to apply).

> However, I guess kvm_pit_state2 will also need some flags field and a
> bit tail room for potential future extensions.
>   

Yes, it's a common pattern in kvm.

-- 
error compiling committee.c: too many arguments to function


  reply	other threads:[~2009-06-14  9:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12  1:46 [PATCH 1/5] Userspace changes for configuring irq0->inti2 override (v6) Beth Kon
2009-06-12  1:46 ` [PATCH 2/5] " Beth Kon
2009-06-12  1:46 ` [PATCH 3/5] BIOS changes for KVM HPET (v6) Beth Kon
2009-06-12  1:46 ` [PATCH 4/5] Userspace " Beth Kon
2009-06-14  8:55   ` Avi Kivity
2009-06-14  9:00     ` Avi Kivity
2009-06-12  1:46 ` [PATCH 5/5] HPET interaction with in-kernel PIT (v6) Beth Kon
2009-06-14  8:53   ` Avi Kivity
2009-06-14  9:10     ` Jan Kiszka
2009-06-14  9:18       ` Avi Kivity
2009-06-14  9:26         ` Jan Kiszka
2009-06-14  9:35           ` Avi Kivity [this message]
2009-06-14  8:50 ` [PATCH 1/5] Userspace changes for configuring irq0->inti2 override (v6) Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A34C44D.8020803@redhat.com \
    --to=avi@redhat.com \
    --cc=eak@us.ibm.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.