From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm broken after ./configure --disable-kvm Date: Sun, 14 Jun 2009 15:58:39 +0300 Message-ID: <4A34F3FF.7040605@redhat.com> References: <4A30FBA3.1070404@us.ibm.com> <4A310C58.6050301@web.de> <4A34DB51.3050700@redhat.com> <4A34DE41.7070506@web.de> <4A34DFA8.1060103@redhat.com> <4A34F15D.4000704@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Beth Kon , Glauber Costa , kvm To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42913 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752763AbZFNM6k (ORCPT ); Sun, 14 Jun 2009 08:58:40 -0400 In-Reply-To: <4A34F15D.4000704@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: >>> 2. Upstream does not, and it's unclear if it ever will (if we push >>> recent headers into kvm-kmod, I think there is no urgent need >>> anymore). At least for code to-be-pushed upstream, we must not >>> rely in this anyway. >>> >> Yes. >> >> Adding the headers to kvm-kmod.h is the right thing technically, but >> something tells me we'll get a lot of failures by people compiling first >> and installing later, rather than the sequence needed to make things >> work: compile and install kvm-kmod, compile and install qemu[-kvm]. Not >> all of the failures will be visible at compile time. >> >> > > That could (and probably should - independent of in-tree headers) be > caught by making all KVM_CAPs mandatory, ie. check for the latest and > greatest ones during configure and drop all the #ifdefs from the code. > Not with out-of-tree headers. qemu-kvm-0.10.x ought to build against Linux 2.6.27, kvm-kmod-2.6.30, and kvm-91. Making all KVM_CAPs mandatory only works if we carry the headers with qemu. > Whatever the strategy will be, it should be one with the clear goal to > converge over the same approach with upstream. > Definitely. In this case I'm still not sure what we want, though. -- error compiling committee.c: too many arguments to function