From: Gerd Hoffmann <kraxel@redhat.com>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] alsa: fix warning
Date: Thu, 18 Jun 2009 08:27:53 +0200 [thread overview]
Message-ID: <4A39DE69.4040308@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0906172215220.2192@linmac.oyster.ru>
On 06/17/09 20:15, malc wrote:
> On Wed, 17 Jun 2009, Gerd Hoffmann wrote:
>
>> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
>> ---
>> audio/alsaaudio.c | 10 ++++++----
>> 1 files changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c
>> index 2f6c764..f1d573a 100644
>> --- a/audio/alsaaudio.c
>> +++ b/audio/alsaaudio.c
>> @@ -626,8 +626,9 @@ static int alsa_init_out (HWVoiceOut *hw, struct audsettings *as)
>> req.period_size = conf.period_size_out;
>> req.buffer_size = conf.buffer_size_out;
>> req.size_in_usec = conf.size_in_usec_out;
>> - req.override_mask = !!conf.period_size_out_overridden
>> - | (!!conf.buffer_size_out_overridden<< 1);
>> + req.override_mask =
>> + (conf.period_size_out_overridden ? 1 : 0) |
>> + (conf.buffer_size_out_overridden ? 2 : 0);
>>
> [..snip..]
>
> What warning does that fix?
>
CC audio/alsaaudio.o
cc1: warnings being treated as errors
/home/kraxel/projects/qemu/audio/alsaaudio.c: In function ‘alsa_init_out’:
/home/kraxel/projects/qemu/audio/alsaaudio.c:630: error: suggest
parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
/home/kraxel/projects/qemu/audio/alsaaudio.c: In function ‘alsa_init_in’:
/home/kraxel/projects/qemu/audio/alsaaudio.c:710: error: suggest
parentheses around operand of ‘!’ or change ‘|’ to ‘||’ or ‘!’ to ‘~’
make: *** [audio/alsaaudio.o] Error 1
cheers,
Gerd
prev parent reply other threads:[~2009-06-18 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-17 11:51 [Qemu-devel] [PATCH v2] alsa: fix warning Gerd Hoffmann
2009-06-17 18:15 ` malc
2009-06-18 6:27 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A39DE69.4040308@redhat.com \
--to=kraxel@redhat.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.