From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Date: Sat, 20 Jun 2009 18:16:12 +0300 Subject: [U-Boot] [PATCH 1/3] OMAP3 I2C Fix the sampling clock. In-Reply-To: <4A3CB876.9080002@windriver.com> References: <1245356024-2138-1-git-send-email-Tom.Rix@windriver.com> <1245356024-2138-2-git-send-email-Tom.Rix@windriver.com> <7A436F7769CA33409C6B44B358BFFF0C0115F502A6@dlee02.ent.ti.com> <4A3CB876.9080002@windriver.com> Message-ID: <4A3CFD3C.5030002@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Tom said the following on 06/20/2009 01:22 PM: > Menon, Nishanth wrote: > >>> -----Original Message----- >>> From: Tom Rix [mailto:Tom.Rix at windriver.com] >>> Sent: Thursday, June 18, 2009 11:14 PM >>> To: u-boot at lists.denx.de; Menon, Nishanth; dirk.behme at googlemail.com >>> Cc: Tom Rix >>> Subject: [PATCH 1/3] OMAP3 I2C Fix the sampling clock. >>> >>> >> Acked-by: Nishanth Menon >> >> There is one comment below though.. >> >> >>> Signed-off-by: Tom Rix >>> --- >>> drivers/i2c/omap24xx_i2c.c | 34 +++++++++++++++++++----- >>> include/asm-arm/arch-omap3/i2c.h | 54 >>> +++++++++++++++++++++++++++++++++----- >>> 2 files changed, 74 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/i2c/omap24xx_i2c.c b/drivers/i2c/omap24xx_i2c.c >>> index 6784603..ecdf1f2 100644 >>> --- a/drivers/i2c/omap24xx_i2c.c >>> +++ b/drivers/i2c/omap24xx_i2c.c >>> @@ -31,7 +31,29 @@ static void flush_fifo(void); >>> >>> void i2c_init (int speed, int slaveadd) >>> { >>> - u16 scl; >>> + int psc, scll, sclh; >>> + >>> + /* Only handle standard and fast speeds */ >>> + if ((speed != OMAP_I2C_STANDARD) && >>> + (speed != OMAP_I2C_FAST_MODE)) { >>> + printf("Error : I2C unsupported speed %d\n", speed); >>> + return; >>> + } >>> + >>> >>> >> We may want to bring the HSI2C support back in though >> >> >> > How about I do this in a later patch? > The configs I looked at only used the much slower standard speed. > Sounds good as long as it is in TODO somewhere.. kinda sad if we talk 400khz to TWL5030 which could go upto 2.4mhz or so.. Regards, Nishanth Menon