From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Mon, 22 Jun 2009 22:04:05 +0200 Subject: [U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size In-Reply-To: <4A3FE10D.50601@freescale.com> References: <1242050635-7152-1-git-send-email-sr@denx.de> <4A3FCF8F.1050405@googlemail.com> <4A3FD276.4090503@freescale.com> <200906222126.32562.sr@denx.de> <4A3FE036.1060009@googlemail.com> <4A3FE10D.50601@freescale.com> Message-ID: <4A3FE3B5.7060608@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott Wood wrote: > Dirk Behme wrote: >> What I still miss: If this warning indicates that something *is* >> wrong, why not run MAKEALL and enable it in config for all boards that >> show this warning? What's the advantage of having all maintainers >> sending patches for their boards? > > 1. That requires having all toolchains installed, and Hmm? In nand_util.c we have #if !defined(CONFIG_SYS_64BIT_VSPRINTF) #warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output! #endif and in Makefile we have ifdef CONFIG_CMD_NAND ifndef CONFIG_NAND_LEGACY ... COBJS-y += nand_util.o endif So I would assume that this warning appears for all boards having CONFIG_CMD_NAND enabled and no CONFIG_NAND_LEGACY and no CONFIG_SYS_64BIT_VSPRINTF? Independent of tool chain? > 2. That does nothing to prevent future boards from being added that are > missing the dependency. Ok, for future boards this warning is fine. But I talk about all the existing boards. Best regards Dirk