[Qemu-devel] [PATCH] configure: don't assume presence of sdl-config

[Qemu-devel] [PATCH] configure: don't assume presence of sdl-config

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 504 bytes --]


Hi!

Don't assume sdl-config is present when checking if SDL is there.
If sdl is not installed, configure prints this error:

sdl-config: No such file or directory

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: qemu_configure.diff --]
[-- Type: text/x-diff, Size: 573 bytes --]

diff --git a/configure b/configure
index eb9d73a..d57fd39 100755
--- a/configure
+++ b/configure
@@ -863,8 +863,17 @@ fi
 
 sdl_too_old=no
 
+# Before we use sdl-config, check if it is there
 if test "$sdl" = "yes" ; then
-    sdl_config="sdl-config"
+    sdl_config=`which sdl-config`
+    if test $? -ne 0 ; then
+        # Clear content if sdl isn't installed.
+        # For example, Solaris 'which' prints "no sdl-config in $PATH"
+        sdl_config=""
+        sdl="no"
+    fi
+fi
+if test "$sdl" = "yes" -a -n "$sdl_config" ; then
     sdl=no
     sdl_static=no
 

Re: [Qemu-devel] [PATCH] configure: don't assume presence of sdl-config

[Anthony Liguori]

Christoph Egger wrote:
> Hi!
>
> Don't assume sdl-config is present when checking if SDL is there.
> If sdl is not installed, configure prints this error:
>
> sdl-config: No such file or directory
>
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
>   
`which sdl-config` will result in an error message going to stderr if 
sdl-config is not found.

Regards,

Anthony Liguori

Re: [Qemu-devel] [PATCH] configure: don't assume presence of sdl-config

[Christoph Egger]

On Thursday 09 July 2009 21:55:29 Anthony Liguori wrote:
> Christoph Egger wrote:
> > Hi!
> >
> > Don't assume sdl-config is present when checking if SDL is there.
> > If sdl is not installed, configure prints this error:
> >
> > sdl-config: No such file or directory
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> `which sdl-config` will result in an error message going to stderr if
> sdl-config is not found.

Right. The intention of the patch is to suppress this.
It is enough when configure prints "sdl: no"

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: [Qemu-devel] [PATCH] configure: don't assume presence of sdl-config

[Anthony Liguori]

Christoph Egger wrote:
> On Thursday 09 July 2009 21:55:29 Anthony Liguori wrote:
>   
>> Christoph Egger wrote:
>>     
>>> Hi!
>>>
>>> Don't assume sdl-config is present when checking if SDL is there.
>>> If sdl is not installed, configure prints this error:
>>>
>>> sdl-config: No such file or directory
>>>
>>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>>>       
>> `which sdl-config` will result in an error message going to stderr if
>> sdl-config is not found.
>>     
>
> Right. The intention of the patch is to suppress this.
> It is enough when configure prints "sdl: no"
>   

Right, so the patch is unsuccessful in doing that :-)

You need something like `which sdl-config 2> /dev/null`

Regards,

Anthony Liguori

> Christoph
>
>