From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756878AbZGJT5V (ORCPT ); Fri, 10 Jul 2009 15:57:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753916AbZGJT5M (ORCPT ); Fri, 10 Jul 2009 15:57:12 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39901 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389AbZGJT5L (ORCPT ); Fri, 10 Jul 2009 15:57:11 -0400 Message-ID: <4A579D9A.1010306@redhat.com> Date: Fri, 10 Jul 2009 15:59:22 -0400 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Li Zefan CC: Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm , DLE , Ananth N Mavinakayanahalli , Christoph Hellwig , Frederic Weisbecker , Tom Zanussi Subject: Re: [PATCH -tip -v11 11/11] tracing: Add kprobes event profiling interface References: <20090709202220.13223.97114.stgit@localhost.localdomain> <20090709202327.13223.16418.stgit@localhost.localdomain> <4A56E3D8.3010806@cn.fujitsu.com> In-Reply-To: <4A56E3D8.3010806@cn.fujitsu.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Li Zefan wrote: >> +Event Profiling >> +--------------- >> + You can check the total number of probe hits and probe miss-hits via >> +/sys/kernel/debug/tracing/kprobe_profile. >> + The fist column is event name, the second is the number of probe hits, > > s/fist/first Oops, fixed. > >> +the third is the number of probe miss-hits. >> + >> + > ... >> +/* Probes profiling interfaces */ >> +static int profile_seq_show(struct seq_file *m, void *v) >> +{ >> + struct trace_probe *tp = v; >> + >> + if (tp == NULL) >> + return 0; >> + > > tp will never be NULL, which is guaranteed by seq_file OK, fixed. >> + seq_printf(m, "%s", tp->call.name); >> + >> + seq_printf(m, "\t%8lu %8lu\n", tp->nhits, >> + probe_is_return(tp) ? tp->rp.kp.nmissed : tp->kp.nmissed); >> + >> + return 0; >> +} Thank you for review! -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -tip -v11 11/11] tracing: Add kprobes event profiling interface Date: Fri, 10 Jul 2009 15:59:22 -0400 Message-ID: <4A579D9A.1010306@redhat.com> References: <20090709202220.13223.97114.stgit@localhost.localdomain> <20090709202327.13223.16418.stgit@localhost.localdomain> <4A56E3D8.3010806@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Ingo Molnar , Steven Rostedt , lkml , systemtap , kvm , DLE , Ananth N Mavinakayanahalli , Christoph Hellwig , Frederic Weisbecker , Tom Zanussi To: Li Zefan Return-path: In-Reply-To: <4A56E3D8.3010806@cn.fujitsu.com> List-Unsubscribe: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org List-Id: kvm.vger.kernel.org Hi, Li Zefan wrote: >> +Event Profiling >> +--------------- >> + You can check the total number of probe hits and probe miss-hits via >> +/sys/kernel/debug/tracing/kprobe_profile. >> + The fist column is event name, the second is the number of probe hits, > > s/fist/first Oops, fixed. > >> +the third is the number of probe miss-hits. >> + >> + > ... >> +/* Probes profiling interfaces */ >> +static int profile_seq_show(struct seq_file *m, void *v) >> +{ >> + struct trace_probe *tp = v; >> + >> + if (tp == NULL) >> + return 0; >> + > > tp will never be NULL, which is guaranteed by seq_file OK, fixed. >> + seq_printf(m, "%s", tp->call.name); >> + >> + seq_printf(m, "\t%8lu %8lu\n", tp->nhits, >> + probe_is_return(tp) ? tp->rp.kp.nmissed : tp->kp.nmissed); >> + >> + return 0; >> +} Thank you for review! -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com