All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Huber <shuber2@gmail.com>
To: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Peter Meerwald <pmeerw@cosy.sbg.ac.at>,
	James Morris <jmorris@namei.org>,
	William Irwin <wli@movementarian.org>, Mel Gorman <mel@csn.ul.ie>,
	Ravikiran G Thirumalai <kiran@scalex86.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: fix hugetlb bug due to user_shm_unlock call (fwd)
Date: Mon, 24 Aug 2009 15:56:05 +0200	[thread overview]
Message-ID: <4A929BF5.2050105@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0908241258070.27704@sister.anvils>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

> However, though I can well believe that your patch works well for you,
> I don't think it's general enough: there is no guarantee that the tests
> in can_do_hugetlb_shm() will give the same answer to the user who ends
> up calling shm_destroy() as it did once upon a time to the user who
> called hugetlb_file_setup().
> 
> So, please could you try this alternative patch below, to see if it
> passes your testing too, and let us know the result?  I'm sure we'd
> like to get a fix into 2.6.31, and into 2.6.30-stable.


Yes, your observation is right and your modified patch works good for
me.

So long
Stefan




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

  reply	other threads:[~2009-08-24 13:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-24  1:11 [PATCH] mm: fix hugetlb bug due to user_shm_unlock call (fwd) James Morris
2009-08-24 12:27 ` Hugh Dickins
2009-08-24 12:27   ` Hugh Dickins
2009-08-24 13:56   ` Stefan Huber [this message]
2009-08-24 15:30     ` [PATCH] mm: fix hugetlb bug due to user_shm_unlock call Hugh Dickins
2009-08-24 15:30       ` Hugh Dickins
2009-08-25  7:36       ` Mel Gorman
2009-08-25  7:36         ` Mel Gorman
2009-09-11 14:03       ` Mike Frysinger
2009-09-11 14:03         ` Mike Frysinger
2009-09-12 11:17         ` Hugh Dickins
2009-09-12 11:21           ` [PATCH] fix undefined reference to user_shm_unlock Hugh Dickins
2009-09-12 11:21             ` Hugh Dickins
2009-09-12 11:41             ` Mike Frysinger
2009-09-12 11:41               ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A929BF5.2050105@gmail.com \
    --to=shuber2@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=jmorris@namei.org \
    --cc=kiran@scalex86.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=pmeerw@cosy.sbg.ac.at \
    --cc=wli@movementarian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.