From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MgwC0-0002zD-Mq
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 03:48:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MgwBw-0002tA-SM
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 03:48:16 -0400
Received: from [199.232.76.173] (port=38863 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MgwBw-0002t0-OL
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 03:48:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34354)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1MgwBw-00086B-5G
	for qemu-devel@nongnu.org; Fri, 28 Aug 2009 03:48:12 -0400
Message-ID: <4A978BAD.6050808@redhat.com>
Date: Fri, 28 Aug 2009 09:47:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1251291946-25821-1-git-send-email-glommer@redhat.com>
	<1251291946-25821-2-git-send-email-glommer@redhat.com>
	<1251291946-25821-3-git-send-email-glommer@redhat.com>
	<1251291946-25821-4-git-send-email-glommer@redhat.com>
	<1251291946-25821-5-git-send-email-glommer@redhat.com>
	<1251291946-25821-6-git-send-email-glommer@redhat.com>
	<m3y6p6ciif.fsf@neno.mitica>
	<20090827173645.GB5746@mothafucka.localdomain>
In-Reply-To: <20090827173645.GB5746@mothafucka.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 05/12] fix broken migration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Glauber Costa <glommer@redhat.com>
Cc: aliguori@us.ibm.com, Juan Quintela <quintela@trasno.org>, qemu-devel@nongnu.org


>> Please drop this one.  I agree with bonzini here.
>> It breaks completely incoming migration, and conflicts with semantics of
>> next one.
> wrong semantics is not a problem here, as long as we keep the same semantics.
>
> For master, I can agree that the work you've done leave us at a better shape, but
> for stable-0.10, this patch is totally needed for migration to work.

Not at all, 6/12 (in particular changing the if to else if) does the same.

Paolo