From: Tao Ma <tao.ma@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 13/14] ocfs2: Set xattr block entries with ocfs2_xa_set()
Date: Wed, 02 Sep 2009 10:50:42 +0800 [thread overview]
Message-ID: <4A9DDD82.3040100@oracle.com> (raw)
In-Reply-To: <1251448563-12508-14-git-send-email-joel.becker@oracle.com>
Joel Becker wrote:
> ocfs2_xattr_block_set() calls into ocfs2_xattr_set_entry() with just the
> HAS_XATTR flag. Most of the machinery of ocfs2_xattr_set_entry() is
> skipped. All that really happens other than the call to ocfs2_xa_set()
> is making sure the HAS_XATTR flag is set on the inode.
>
> But HAS_XATTR should be set when we also set di->i_xattr_loc. And
> that's done in ocfs2_xattr_block_set(). So let's move it there, and
it is done in ocfs2_create_xattr_block actually. ;)
Otherwise it looks good.
Regards,
Tao
next prev parent reply other threads:[~2009-09-02 2:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 8:35 [Ocfs2-devel] [PATCH 0/14] ocfs2: Unify the setting of extended attributes Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 01/14] ocfs2: Introduce ocfs2_xa_loc Joel Becker
2009-09-01 5:32 ` Tao Ma
2009-09-01 8:26 ` Joel Becker
2009-09-01 8:45 ` Joel Becker
2009-09-01 8:49 ` Tao Ma
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 02/14] ocfs2: Remove xattrs via ocfs2_xa_loc Joel Becker
2009-09-01 6:03 ` Tao Ma
2009-09-01 8:28 ` Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 03/14] ocfs2: Prefix the member fields of struct ocfs2_xattr_info Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 04/14] ocfs2: Add a name_len field to ocfs2_xattr_info Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 05/14] ocfs2: Wrap calculation of name+value pair size Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 06/14] ocfs2: Set the xattr name+value pair in one place Joel Becker
2009-09-01 7:33 ` Tao Ma
2009-09-01 8:30 ` Joel Becker
2009-09-01 8:47 ` Tao Ma
2009-09-01 9:30 ` Joel Becker
2009-09-01 12:12 ` Tao Ma
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 07/14] ocfs2: Handle value tree roots in ocfs2_xa_set_inline_value() Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 08/14] ocfs2: Provide ocfs2_xa_fill_value_buf() for external value processing Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 09/14] ocfs2: Teach ocfs2_xa_loc how to do its own journal work Joel Becker
2009-08-28 8:35 ` [Ocfs2-devel] [PATCH 10/14] ocfs2: Allocation in ocfs2_xa_prepare_entry() values in ocfs2_xa_store_value() Joel Becker
2009-09-01 8:55 ` Tao Ma
2009-09-01 20:21 ` Joel Becker
2009-09-02 1:51 ` Joel Becker
2009-09-02 4:59 ` Tao Ma
2009-09-02 8:05 ` Joel Becker
2009-09-02 8:37 ` Joel Becker
2009-09-02 9:01 ` tristan.ye
2009-09-02 10:24 ` Joel Becker
2009-09-02 10:31 ` Joel Becker
2009-09-03 10:48 ` tristan.ye
2009-09-05 1:35 ` Joel Becker
2009-09-08 1:25 ` tristan.ye
2009-08-28 8:36 ` [Ocfs2-devel] [PATCH 11/14] ocfs2: Gell into ocfs2_xa_set() Joel Becker
2009-08-28 8:36 ` [Ocfs2-devel] [PATCH 12/14] ocfs2: Let ocfs2_xa_prepare_entry() do space checks Joel Becker
2009-09-02 1:54 ` Tao Ma
2009-09-02 2:11 ` Joel Becker
2009-09-02 2:21 ` Tao Ma
2009-08-28 8:36 ` [Ocfs2-devel] [PATCH 13/14] ocfs2: Set xattr block entries with ocfs2_xa_set() Joel Becker
2009-09-02 2:50 ` Tao Ma [this message]
2009-08-28 8:36 ` [Ocfs2-devel] [PATCH 14/14] ocfs2: Set inline xattr " Joel Becker
2009-09-02 2:58 ` Tao Ma
-- strict thread matches above, loose matches on Subject: below --
2009-08-19 19:54 [Ocfs2-devel] [PATCH 0/14] ocfs2: Unify the setting of extended attributes Joel Becker
2009-08-19 19:54 ` [Ocfs2-devel] [PATCH 13/14] ocfs2: Set xattr block entries with ocfs2_xa_set() Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9DDD82.3040100@oracle.com \
--to=tao.ma@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.