From: "H. Peter Anvin" <hpa@zytor.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Richard Kettlewell <rjk@terraraq.org.uk>
Subject: Re: [PATCH] x86: Fix code patching for paravirt-alternatives on 486
Date: Tue, 08 Sep 2009 18:00:50 -0700 [thread overview]
Message-ID: <4AA6FE42.9070700@zytor.com> (raw)
In-Reply-To: <1252457195.3423.124.camel@localhost>
On 09/08/2009 05:46 PM, Ben Hutchings wrote:
> On Tue, 2009-09-08 at 17:31 -0700, H. Peter Anvin wrote:
> [...]
>> I'm wondering if it wouldn't be cleaner to fold the jump into
>> sync_core() and moving the sync_core() up before local_irq_restore().
>
> Exactly as I suggested below the dashes. :-)
>
Ah, yes, so you did indeed.
> The only reason I didn't do that initially was that I don't know whether
> or not there's a good reason for the current placement of sync_core()
> after local_irq_restore().
I can personally not fathom how moving the sync_core() before
local_irq_restore() could cause problems -- in fact, the current code
seems logically wrong, although probably correct in practice, as the
interrupt itself should perform the necessary synchronization (although
it is not architecturally required to do so.) Not that I haven't been
wrong before.
-hpa
prev parent reply other threads:[~2009-09-09 1:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 23:23 [PATCH] x86: Fix code patching for paravirt-alternatives on 486 Ben Hutchings
2009-09-09 0:31 ` H. Peter Anvin
2009-09-09 0:46 ` Ben Hutchings
2009-09-09 1:00 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA6FE42.9070700@zytor.com \
--to=hpa@zytor.com \
--cc=ben@decadent.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rjk@terraraq.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.