From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] virtio_console: Add support for multiple ports for generic guest and host communication Date: Fri, 11 Sep 2009 12:35:18 -0500 Message-ID: <4AAA8A56.3040707__20817.6595428542$1252690810$gmane$org@codemonkey.ws> References: <1252678386-17404-1-git-send-email-amit.shah@redhat.com> <1252678386-17404-2-git-send-email-amit.shah@redhat.com> <20090911170010.34c80f2d@linux.intel.com> <20090911163806.GB25535@amit-x200.redhat.com> <4AAA8838.1080106@codemonkey.ws> <20090911173307.GB27046@amit-x200.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090911173307.GB27046@amit-x200.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Amit Shah Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Alan Cox List-Id: virtualization@lists.linuxfoundation.org Amit Shah wrote: > On (Fri) Sep 11 2009 [12:26:16], Anthony Liguori wrote: > >> Amit Shah wrote: >> >>> Right; there was some discussion about this. A few alternatives were >>> suggested like >>> >>> - udev scripts to create symlinks from ports to function, like: >>> >>> /dev/vcon3 -> /dev/virtio-console/clipboard >>> >>> - Some fqdn-like hierarchy, like >>> >>> /dev/virtio-console/com/redhat/clipboard >>> >>> which again can be created by udev scripts >>> >>> >> And I dislike all of them. What I'd rather have is these devices >> exposed as tty's with a sys attribute that exposed the name of the >> device. >> > > A sysfs attribute can even be exposed with a char device. > > I didn't want to venture more into tty after the hvc thing and the > unexpected bugs that crept up (memory corruption, which is now fixed in > linux-next). I'd rather just keep it limited to the subsystems I know. > I don't think that's a good justification. This device is very much a serial port. I don't see any reason not to treat it like one. Regards, Anthony Liguori