All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: VCT: Remove read_spareram reference
Date: Sat, 12 Sep 2009 13:12:24 +0900	[thread overview]
Message-ID: <4AAB1FA8.6070409@pobox.com> (raw)
In-Reply-To: <20090721025804.GA3722@july>

The commit ecad289fc6bd9d89ef4d5093cc7b6fd712fd0d29 (OneNAND: Remove
unused read_spareram and add unlock_all as kernel does) forgot to fixup
a local reference to read_spareram in board/micronas/vct/ebi_onenand.c,
which causes the following build failure when configured with OneNAND:

ebi_onenand.c: In function 'onenand_board_init':
ebi_onenand.c:196: error: 'struct onenand_chip' has no member named 'read_spareram'
make[1]: *** [ebi_onenand.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [board/micronas/vct/libvct.a] Error 2

Signed-off-by: Shinya Kuribayashi <skuribay@pobox.com>
Cc: Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---

 Wolfgang, once approved by a board maintainer, please apply directly.
 Thanks in advance,

 board/micronas/vct/ebi_onenand.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/board/micronas/vct/ebi_onenand.c b/board/micronas/vct/ebi_onenand.c
index 522b88f..1e8afa6 100644
--- a/board/micronas/vct/ebi_onenand.c
+++ b/board/micronas/vct/ebi_onenand.c
@@ -193,6 +193,5 @@ void onenand_board_init(struct mtd_info *mtd)
 	chip->write_word = ebi_nand_write_word;
 
 	chip->read_bufferram = ebi_read_bufferram;
-	chip->read_spareram = ebi_read_bufferram;
 	chip->write_bufferram = ebi_write_bufferram;
 }

  parent reply	other threads:[~2009-09-12  4:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-21  2:58 [U-Boot] [PATCH] OneNAND: Remove unused read_spareram Kyungmin Park
2009-08-06 22:01 ` Scott Wood
2009-08-26 20:07 ` Wolfgang Denk
2009-09-12  4:12 ` Shinya Kuribayashi [this message]
2009-09-12  6:30   ` [U-Boot] [PATCH] MIPS: VCT: Remove read_spareram reference Stefan Roese
2009-09-12  9:01     ` [U-Boot] [PATCH v2] " Shinya Kuribayashi
2009-09-18 18:44       ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AAB1FA8.6070409@pobox.com \
    --to=skuribay@pobox.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.