All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, Roland McGrath <roland@redhat.com>
Subject: Re: [PATCH 02/10] x86: Convert BUG() to use unreachable()
Date: Sun, 13 Sep 2009 13:12:03 -0700	[thread overview]
Message-ID: <4AAD5213.8060205@zytor.com> (raw)
In-Reply-To: <4AAA72F3.9090103@caviumnetworks.com>

On 09/11/2009 08:55 AM, David Daney wrote:
> 
> Perhaps, although with a pre-GCC-4.5 compiler, it would end up adding
> the endless loop code to BUG() sites for configurations where the user
> has explicitly stated their preference for the code to be as small as
> possible (by turning off CONFIG_BUG).
> 
> If that is acceptable, I will prepare another revision of the patch set.
> 

The thing is that without the loop, the compiler will generate the
fall-through case code, which may add more code than the loop removes.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


  reply	other threads:[~2009-09-13 20:13 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 23:54 [PATCH 00/10] Add support for GCC's __builtin_unreachable() and use it in BUG David Daney
2009-09-10 23:54 ` David Daney
2009-09-10 23:56 ` [PATCH 01/10] Add support for GCC-4.5's __builtin_unreachable() to compiler.h David Daney
2009-09-10 23:56   ` David Daney
2009-09-10 23:56   ` David Daney
2009-09-10 23:56   ` David Daney
2009-09-11  0:14   ` Richard Henderson
2009-09-11  0:14     ` Richard Henderson
2009-09-11  0:14     ` Richard Henderson
2009-09-11 14:32   ` Michael Buesch
2009-09-11 14:32     ` Michael Buesch
2009-09-11 14:32     ` Michael Buesch
2009-09-11 15:58     ` David Daney
2009-09-11 15:58       ` David Daney
2009-09-11 15:58       ` David Daney
2009-09-11 15:58       ` David Daney
2009-09-12  7:22       ` Geert Uytterhoeven
2009-09-12  7:22         ` Geert Uytterhoeven
2009-09-12  7:22         ` Geert Uytterhoeven
2009-09-12  7:22         ` Geert Uytterhoeven
2009-09-12  7:22         ` Geert Uytterhoeven
2009-09-12  7:22         ` Geert Uytterhoeven
2009-09-14 15:40         ` David Daney
2009-09-14 15:40           ` David Daney
2009-09-14 15:40           ` David Daney
2009-09-14 15:40           ` David Daney
2009-09-10 23:56 ` [PATCH 02/10] x86: Convert BUG() to use unreachable() David Daney
2009-09-11  0:56   ` H. Peter Anvin
2009-09-11  1:09     ` Roland McGrath
2009-09-11  1:13     ` Linus Torvalds
2009-09-11  1:33       ` H. Peter Anvin
2009-09-11  1:37       ` Roland McGrath
2009-09-11  1:42         ` H. Peter Anvin
2009-09-11  6:07       ` Ingo Molnar
2009-09-11 15:55         ` David Daney
2009-09-13 20:12           ` H. Peter Anvin [this message]
2009-09-10 23:56 ` [PATCH 03/10] MIPS: " David Daney
2009-09-10 23:56 ` [PATCH 04/10] s390: " David Daney
2009-09-11 12:18   ` Martin Schwidefsky
2009-09-11 12:18     ` Martin Schwidefsky
2009-09-10 23:56 ` [PATCH 05/10] mn10300: " David Daney
2009-09-10 23:56 ` [PATCH 06/10] parisc: " David Daney
2009-09-28  3:20   ` Kyle McMartin
2009-09-10 23:56 ` [PATCH 07/10] powerpc: " David Daney
2009-09-10 23:56   ` David Daney
2009-09-10 23:56 ` [PATCH 08/10] alpha: " David Daney
2009-09-10 23:56 ` [PATCH 09/10] avr32: " David Daney
2009-09-11  7:31   ` Haavard Skinnemoen
2009-09-10 23:56 ` [PATCH 10/10] blackfin: " David Daney
2009-09-24  3:37 ` [PATCH 00/10] Add support for GCC's __builtin_unreachable() and use it in BUG Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AAD5213.8060205@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=ddaney@caviumnetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.