From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pavel Hofman <pavel.hofman@ivitera.com>
Subject: Re: [PATCH 1/6] AK4114 - fix output selector bits,
	fix spelling
Date: Tue, 15 Sep 2009 13:51:16 +0200
Message-ID: <4AAF7FB4.7020401@ivitera.com>
References: <1252968303-29334-1-git-send-email-pavel.hofman@ivitera.com>
	<s5hskeobh4p.wl%tiwai@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from server.insite.cz (upc-plzen.insite.cz [84.242.100.8])
	by alsa0.perex.cz (Postfix) with ESMTP id 3A0FE1037F3
	for <alsa-devel@alsa-project.org>;
	Tue, 15 Sep 2009 13:50:56 +0200 (CEST)
In-Reply-To: <s5hskeobh4p.wl%tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

Takashi Iwai wrote:
> At Tue, 15 Sep 2009 00:44:58 +0200,
> pavel.hofman@ivitera.com wrote:
>> From: Pavel Hofman <pavel.hofman@ivitera.com>
>>
>>
>> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> 
> Could you give a bit more changelog content?
> The summary line isn't enough for non-trivial changes.
> In this case, you changed AK4114_OPS1[012] values without any
> explanation.  Please give a bit more information, what these changes
> mean, what impact they have, etc.

Sure, I was not sure how the rules apply in git. The first line in
rebase/patch edit is a summary statement and next lines are the detailed
changelog? Thanks a lot for the info.

Pavel.
> 
> 
> thanks,
> 
> Takashi
> 
>> diff --git a/include/ak4114.h b/include/ak4114.h
>> index d293d36..3ce69fd 100644
>> --- a/include/ak4114.h
>> +++ b/include/ak4114.h
>> @@ -95,13 +95,13 @@
>>  
>>  /* AK4114_REG_IO0 */
>>  #define AK4114_TX1E		(1<<7)	/* TX1 Output Enable (1 = enable) */
>> -#define AK4114_OPS12		(1<<2)	/* Output Though Data Selector for TX1 pin */
>> -#define AK4114_OPS11		(1<<1)	/* Output Though Data Selector for TX1 pin */
>> -#define AK4114_OPS10		(1<<0)	/* Output Though Data Selector for TX1 pin */
>> +#define AK4114_OPS12		(1<<6)	/* Output Data Selector for TX1 pin */
>> +#define AK4114_OPS11		(1<<5)	/* Output Data Selector for TX1 pin */
>> +#define AK4114_OPS10		(1<<4)	/* Output Data Selector for TX1 pin */
>>  #define AK4114_TX0E		(1<<3)	/* TX0 Output Enable (1 = enable) */
>> -#define AK4114_OPS02		(1<<2)	/* Output Though Data Selector for TX0 pin */
>> -#define AK4114_OPS01		(1<<1)	/* Output Though Data Selector for TX0 pin */
>> -#define AK4114_OPS00		(1<<0)	/* Output Though Data Selector for TX0 pin */
>> +#define AK4114_OPS02		(1<<2)	/* Output Data Selector for TX0 pin */
>> +#define AK4114_OPS01		(1<<1)	/* Output Data Selector for TX0 pin */
>> +#define AK4114_OPS00		(1<<0)	/* Output Data Selector for TX0 pin */
>>  
>>  /* AK4114_REG_IO1 */
>>  #define AK4114_EFH1		(1<<7)	/* Interrupt 0 pin Hold */
>> -- 
>> 1.5.6.3
>>