From: Marius Storm-Olsen <marius@storm-olsen.com>
To: Alexey Borzenkov <snaury@gmail.com>
Cc: Johannes.Schindelin@gmx.de, msysgit@googlegroups.com,
git@vger.kernel.org, lznuaa@gmail.com, raa.lkml@gmail.com
Subject: Re: [PATCH 04/14] Set _O_BINARY as default fmode for both MinGW and MSVC
Date: Tue, 15 Sep 2009 21:12:59 +0200 [thread overview]
Message-ID: <4AAFE73B.5010408@gmail.com> (raw)
In-Reply-To: <e2480c70909151207v4d89d302m27aecff0d4a11d45@mail.gmail.com>
Alexey Borzenkov said the following on 15.09.2009 21:07:
> GMail ate the bottom half of my message... again. :( Seems like
> there's a strange bug in copy/pasting, I better compose long emails
> in TextMate from now on. Here's a "reconstruction":
>
> On Tue, Sep 15, 2009 at 5:44 PM, Marius Storm-Olsen
> <mstormo@gmail.com> wrote:
>> +extern int _fmode;
>
> And indeed. I just ported this patch to my custom msysgit branch
> (based on v1.6.4.3) and it didn't compile:
Hmmm, I compile this fine with both MinGW from the msysgit 'devel'
branch, and MSVC; but I see your point.
I'll give your updated patch a roll tomorrow. Thanks
--
.marius
next prev parent reply other threads:[~2009-09-15 19:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 13:44 [RFC/PATCH v3 00/14] Build Git with MSVC Marius Storm-Olsen
[not found] ` <cover.1253021728.git.mstormo@gmail.com>
2009-09-15 13:44 ` [PATCH 01/14] Avoid declaration after statement Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 02/14] Add define guards to compat/win32.h Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 03/14] Change regerror() declaration from K&R style to ANSI C (C89) Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 04/14] Set _O_BINARY as default fmode for both MinGW and MSVC Marius Storm-Olsen
2009-09-15 18:40 ` Alexey Borzenkov
2009-09-15 19:01 ` Alexey Borzenkov
2009-09-15 19:07 ` Alexey Borzenkov
2009-09-15 19:12 ` Marius Storm-Olsen [this message]
2009-09-15 13:44 ` [PATCH 05/14] Fix __stdcall placement and function prototype Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 06/14] Test for WIN32 instead of __MINGW32_ Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 07/14] Add empty header files for MSVC port Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 08/14] Add MinGW header files to build git with MSVC Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 09/14] Add platform files for MSVC porting Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 10/14] Make usage of windows.h lean and mean Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 11/14] Define strncasecmp and ftruncate for MSVC Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 12/14] Add MSVC to Makefile Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 13/14] Add README for MSVC build Marius Storm-Olsen
2009-09-16 1:22 ` Thiago Farina
2009-09-16 5:26 ` Marius Storm-Olsen
2009-09-15 13:44 ` [PATCH 14/14] Add scripts to generate projects for other buildsystems (MSVC vcproj, QMake) Marius Storm-Olsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AAFE73B.5010408@gmail.com \
--to=marius@storm-olsen.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=lznuaa@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=raa.lkml@gmail.com \
--cc=snaury@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.