From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nishanth Menon <menon.nishanth@gmail.com>
Date: Thu, 24 Sep 2009 03:34:39 +0300
Subject: [U-Boot] [PATCH v2] TI: OMAP3: Overo Tobi ethernet support
In-Reply-To: <1D0F4997-6AF4-4BC3-94C3-0817551DBA84@lixom.net>
References: <20090911204750.GA22246@lixom.net>	<20090923145556.GA28659@lixom.net>
	<4ABA6B78.4010005@windriver.com>
	<1D0F4997-6AF4-4BC3-94C3-0817551DBA84@lixom.net>
Message-ID: <4ABABE9F.2020304@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Olof Johansson said the following on 09/23/2009 09:43 PM:
> On Sep 23, 2009, at 1:39 PM, Tom wrote:
>
>   
>> Olof Johansson wrote:
>>     
>>> diff --git a/board/overo/overo.c b/board/overo/overo.c
>>> index dd6d286..7d87e52 100644
>>> --- a/board/overo/overo.c
>>> +++ b/board/overo/overo.c
>>>       
>>> +	writel(GPIO0, &gpio3_base->cleardataout);
>>> +	udelay(1);
>>> +	writel(GPIO0, &gpio3_base->setdataout);
>>>       
>> Use the omap gpio interface described in README.omap3
>>
>>     
>
> Seriously, this code is a 1:1 replica from the evm code. Obviously  
> that code was good enough to merge.
>   

should'nt we be fixing evm code instead of moving similar code in for
another platform?
Regards,
Nishanth Menon