[PATCH] serial8250_tx_empty not telling the truth

[PATCH] serial8250_tx_empty not telling the truth

[Dick Hollenbeck]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

When controlling an industrial radio modem it can be necessary to
manipulate the handshake lines in order to control the radio modem's 
transmitter.
The transmitter should not be turned off before all characters have been 
transmitted.
serial8250_tx_empty() was reporting that all characters were transmitted 
before
they actually were.

Signed-off-by: Dick Hollenbeck <dick@softplc.com>


[-- Attachment #2: 8250.diff --]
[-- Type: text/x-diff, Size: 959 bytes --]

--- drivers/serial/8250.c.orig	2009-09-26 14:06:55.000000000 -0500
+++ drivers/serial/8250.c	2009-09-26 14:12:37.000000000 -0500
@@ -81,6 +81,9 @@ static int serial_index(struct uart_port
 
 #define PASS_LIMIT	256
 
+#define BOTH_EMPTY 	(UART_LSR_TEMT | UART_LSR_THRE)
+
+
 /*
  * We default to IRQ0 for the "no irq" hack.   Some
  * machine types want others as well - they're free
@@ -1792,7 +1795,7 @@ static unsigned int serial8250_tx_empty(
 	up->lsr_saved_flags |= lsr & LSR_SAVE_FLAGS;
 	spin_unlock_irqrestore(&up->port.lock, flags);
 
-	return lsr & UART_LSR_TEMT ? TIOCSER_TEMT : 0;
+	return (lsr & BOTH_EMPTY) == BOTH_EMPTY ? TIOCSER_TEMT : 0;
 }
 
 static unsigned int serial8250_get_mctrl(struct uart_port *port)
@@ -1850,8 +1853,6 @@ static void serial8250_break_ctl(struct 
 	spin_unlock_irqrestore(&up->port.lock, flags);
 }
 
-#define BOTH_EMPTY (UART_LSR_TEMT | UART_LSR_THRE)
-
 /*
  *	Wait for transmitter & holding register to empty
  */