All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: add show_lapic=
Date: Sun, 27 Sep 2009 01:29:22 -0700	[thread overview]
Message-ID: <4ABF2262.3090905@kernel.org> (raw)
In-Reply-To: <20090927080605.GA4984@lenovo>

Cyrill Gorcunov wrote:
> [Yinghai Lu - Sun, Sep 27, 2009 at 12:01:52AM -0700]
> | 
> | so could use that together with apci=debug to print less cpu apic.
> | 
> | otherwise for system have more cpus will take a while
> | 
> | also move apic_verbosity check to print_all_ICs
> | 
> | Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> | 
> | ---
> |  arch/x86/kernel/apic/io_apic.c |   42 ++++++++++++++++++++++++++---------------
> |  1 file changed, 27 insertions(+), 15 deletions(-)
> ...
> 
> Hi Yinghai, good idea!
> 
> I've tuned your patch a bit together with changelog.
> 
> 1) show_lapic=1 by default does change current kernel behaviour
>    so it should be set to max cpu available.

think about system with lots of cpu. but i still want to use apic=debug

> 2) show_lapic contains the max number of lapics being printed
>    so we need to count them instead of plain comparation with
>    cpu number, as a result I've changed print_local_APICs. Or
>    you meant _exactly_ cpuid number? In meaning like
>    show_lapic=max_cpuid. Hmm?
> 
your change anything about that. there is not gap between cpu id.

YH

  reply	other threads:[~2009-09-27  8:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27  7:01 [PATCH] x86: add show_lapic= Yinghai Lu
2009-09-27  8:06 ` Cyrill Gorcunov
2009-09-27  8:29   ` Yinghai Lu [this message]
2009-09-27  8:54     ` Cyrill Gorcunov
2009-09-27 10:28       ` Cyrill Gorcunov
2009-09-27 14:40         ` Cyrill Gorcunov
2009-09-27 17:42           ` Cyrill Gorcunov
2009-09-28 16:07             ` Cyrill Gorcunov
2009-09-28 17:46               ` Yinghai Lu
2009-09-28 18:02                 ` Cyrill Gorcunov
2009-09-30 15:26                   ` Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ABF2262.3090905@kernel.org \
    --to=yinghai@kernel.org \
    --cc=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.