From mboxrd@z Thu Jan  1 00:00:00 1970
From: Felix Radensky <felix@embedded-sol.com>
Date: Tue, 29 Sep 2009 00:17:07 +0200
Subject: [U-Boot] [PATCH] ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling
In-Reply-To: <1254156809-10678-1-git-send-email-sr@denx.de>
References: <1254156809-10678-1-git-send-email-sr@denx.de>
Message-ID: <4AC135E3.8040302@embedded-sol.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi, Stefan

Stefan Roese wrote:
> This patch merges the ECC handling (ECC parity byte writing) into one
> file (ecc.c) for all PPC4xx SDRAM controllers except for PPC440EPx/GRx.
> This exception is because only those PPC's use the completely different
> Denali SDRAM controller core.
>
> Previously we had two routines to generate/write the ECC parity bytes.
> With this patch we now only have one core function left.
>
> Tested on Kilauea (no ECC) and Katmai (with and without ECC).
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Felix Radensky <felix@embedded-sol.com>
> Cc: Grant Erickson <gerickson@nuovations.com>
> Cc: Pieter Voorthuijsen <pv@prodrive.nl>
> ---
> Pieter, the p3p440 is currently the only PPC4xx DDR based board (non DDR2)
> with ECC enabled. Could you please test this patch on the p3p440, and
> let me know if you see any problems?
>
> And Felix & Grant, it would be great if you could test this patch on your
> platforms as well.
>
> Thanks.
>
>   

Patch does not apply. I've tried both u-boot.git and u-boot-ppc4xx.git.

Applying ppc4xx: Merge PPC4xx DDR and DDR2 ECC handling
error: patch failed: cpu/ppc4xx/44x_spd_ddr2.c:198
error: cpu/ppc4xx/44x_spd_ddr2.c: patch does not apply
Patch failed at 0001.

After fixing the problem manually I was able to successfully test
your patch on 405EXr and 460EX boards with ECC.

Thanks a lot.

Felix.