From: Bruce Jones <brucej97223@gmail.com>
To: Joe Perches <joe@perches.com>, gregkh@suse.de
Cc: wfp5@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: Updated: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl7225b.c
Date: Tue, 29 Sep 2009 10:26:29 -0700 [thread overview]
Message-ID: <4AC24345.20809@gmail.com> (raw)
In-Reply-To: <1254176318.28232.388.camel@Joe-Laptop.home>
Joe Perches wrote:
> On Mon, 2009-09-28 at 15:10 -0700, Bruce Jones wrote:
>> Cleanup the printk's in this driver to use KERN_foo log
>> levels.
>> + printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
>> this_board->name, iobase);
>> if (!request_region(iobase, iorange, "acl7225b")) {
>> - printk("I/O port conflict\n");
>> + printk(KERN_CONT "I/O port conflict\n");
>
> This should not be KERN_CONT but KERN_INFO or KERN_ERR
> and should probably have a "comedi%d:" leader.
>
> Maybe:
> printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n");
>
> cheers, Joe
Joe, thanks! Greg, here's an updated patch.
-- brucej
------------------
Clean up the printk's in this driver.
Signed-off-by: Bruce Jones <brucej@linux.com>
---
drivers/staging/comedi/drivers/acl7225b.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/acl7225b.c b/drivers/staging/comedi/drivers/acl7225b.c
index c3652ef..e20c354 100644
--- a/drivers/staging/comedi/drivers/acl7225b.c
+++ b/drivers/staging/comedi/drivers/acl7225b.c
@@ -94,10 +94,11 @@ static int acl7225b_attach(struct comedi_device *dev,
iobase = it->options[0];
iorange = this_board->io_range;
- printk("comedi%d: acl7225b: board=%s 0x%04x ", dev->minor,
+ printk(KERN_INFO "comedi%d: acl7225b: board=%s 0x%04x\n", dev->minor,
this_board->name, iobase);
if (!request_region(iobase, iorange, "acl7225b")) {
- printk("I/O port conflict\n");
+ printk(KERN_ERR "comedi%d: request_region failed - I/O port conflict\n",
+ dev->minor);
return -EIO;
}
dev->board_name = this_board->name;
@@ -137,14 +138,12 @@ static int acl7225b_attach(struct comedi_device *dev,
s->range_table = &range_digital;
s->private = (void *)ACL7225_DI_LO;
- printk("\n");
-
return 0;
}
static int acl7225b_detach(struct comedi_device *dev)
{
- printk("comedi%d: acl7225b: remove\n", dev->minor);
+ printk(KERN_INFO "comedi%d: acl7225b: remove\n", dev->minor);
if (dev->iobase)
release_region(dev->iobase, this_board->io_range);
--
1.6.5.rc2
prev parent reply other threads:[~2009-09-29 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 22:10 Updated: [PATCH] staging: comedi: CodingStyle cleanup for drivers/acl7225b.c Bruce Jones
2009-09-28 22:18 ` Joe Perches
2009-09-29 17:26 ` Bruce Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AC24345.20809@gmail.com \
--to=brucej97223@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wfp5@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.